From: Steven Rostedt <rostedt@goodmis.org>
To: Jason Baron <jbaron@redhat.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@elte.hu>,
Christoph Lameter <cl@linux-foundation.org>
Subject: Re: [RFC PATCH] Tracepoint: introduce tracepoint() API
Date: Thu, 17 Nov 2011 17:27:17 -0500 [thread overview]
Message-ID: <1321568837.3533.19.camel@frodo> (raw)
In-Reply-To: <20111117215817.GB2441@redhat.com>
On Thu, 2011-11-17 at 16:58 -0500, Jason Baron wrote:
> I brought this issue up a while back, with a very similar patch to what
> Mathieu wrote. Please see:
>
> http://thread.gmane.org/gmane.linux.kernel/838911
Ah, I remember this now. Mathieu's version is a bit nicer. And we should
only do this for those places that are the problem cases. Basically only
the places that dereference structures, or have other indirections.
>
> One conclusion from that thread was that it would be nice if gcc could
> optimize the load so that it only happens in the unlikely path. I filed
> a gcc bug for that: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40207,
> but it doesn't seem to be implemented yet...
I agree that this is a compiler issue, but this has been two years and
no progress. Lets go with Mathieu's solution, and we should add a Link:
tag to Jason's patches as well, with a side note that talks about
Jason's previous changes with it.
-- Steve
next prev parent reply other threads:[~2011-11-17 22:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-17 3:55 [RFC] tracepoint/jump_label overhead Eric Dumazet
2011-11-17 15:25 ` Peter Zijlstra
2011-11-17 15:38 ` Avi Kivity
2011-11-17 15:56 ` Mathieu Desnoyers
2011-11-17 20:50 ` [RFC PATCH] Tracepoint: introduce tracepoint() API Mathieu Desnoyers
2011-11-17 21:06 ` Steven Rostedt
2011-11-17 21:58 ` Jason Baron
2011-11-17 22:27 ` Steven Rostedt [this message]
2011-11-17 23:25 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321568837.3533.19.camel@frodo \
--to=rostedt@goodmis.org \
--cc=cl@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).