From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756446Ab1KREJc (ORCPT ); Thu, 17 Nov 2011 23:09:32 -0500 Received: from mga11.intel.com ([192.55.52.93]:31094 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756387Ab1KREJa (ORCPT ); Thu, 17 Nov 2011 23:09:30 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.69,530,1315206000"; d="scan'208";a="92222380" Subject: Re: [PATCH] iwl-debug: Shrink object by using dev_err and deduplicating formats From: "Guy, Wey-Yi" To: Joe Perches Cc: Intel Linux Wireless , "John W. Linville" , "linux-wireless@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <1321580775.22117.8.camel@Joe-Laptop> References: <1321580775.22117.8.camel@Joe-Laptop> Content-Type: text/plain; charset="UTF-8" Date: Thu, 17 Nov 2011 19:14:16 -0800 Message-ID: <1321586056.11647.10.camel@wwguy-huron> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2011-11-17 at 17:46 -0800, Joe Perches wrote: > Using dev_err instead of dev_printk(KERN_ERR uses fewer > arguments and is a bit smaller. > > Deduplicating formats used by IWL_DEBUG_QUIET_RFKILL also > makes the object a bit smaller. > > Neatened the macros, used ##__VA_ARGS__. > > $ size drivers/net/wireless/iwlwifi/built-in.o* > text data bss dec hex filename > 462652 8646 92576 563874 89aa2 drivers/net/wireless/iwlwifi/built-in.o.new > 467557 8646 92592 568795 8addb drivers/net/wireless/iwlwifi/built-in.o.old > > Signed-off-by: Joe Perches Acked-by: Wey-Yi Guy > --- > \ very interesting. Thanks Wey