From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753635Ab1KVHik (ORCPT ); Tue, 22 Nov 2011 02:38:40 -0500 Received: from senator.holtmann.net ([87.106.208.187]:47560 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751716Ab1KVHij (ORCPT ); Tue, 22 Nov 2011 02:38:39 -0500 Message-ID: <1321947516.2011.19.camel@aeonflux> Subject: Re: [Patch] btusb: fix a memory leak in btusb_send_frame() From: Marcel Holtmann To: Cong Wang Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, "Gustavo F. Padovan" , linux-bluetooth@vger.kernel.org Date: Tue, 22 Nov 2011 08:38:36 +0100 In-Reply-To: <1321925578-5407-1-git-send-email-amwang@redhat.com> References: <1321925578-5407-1-git-send-email-amwang@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.1 (3.2.1-2.fc16) Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Cong, > This patch fixes the following memory leak reported by kmemleak: > > unreferenced object 0xffff880060a53840 (size 192): > comm "softirq", pid 0, jiffies 4320571771 (age 1406.569s) > hex dump (first 32 bytes): > 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [] create_object+0x187/0x28b > [] kmemleak_alloc+0x73/0x98 > [] __kmalloc+0xfc/0x123 > [] usb_alloc_urb+0x1e/0x48 > [] btusb_send_frame+0x86/0x385 [btusb] > [] hci_send_frame+0xa0/0xa5 [bluetooth] > [] hci_cmd_task+0xa0/0xfb [bluetooth] > [] tasklet_action+0x8f/0xef > [] __do_softirq+0xf4/0x1db > [] run_ksoftirqd+0x84/0x129 > [] kthread+0xa0/0xa8 > [] kernel_thread_helper+0x4/0x10 > [] 0xffffffffffffffff > > The problem is that when inc_tx() returns non-zero, we forgot > to call usb_free_urb(). > > Cc: Marcel Holtmann > Cc: "Gustavo F. Padovan" > Signed-off-by: WANG Cong Acked-by: Marcel Holtmann Regards Marcel