From: Marcus Folkesson <marcus.folkesson@gmail.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>,
Marcus Folkesson <marcus.folkesson@gmail.com>
Subject: [PATCH] mfd: tps65910: Handle clear-mask correctly
Date: Tue, 22 Nov 2011 14:39:51 +0100 [thread overview]
Message-ID: <1321969191-8604-2-git-send-email-marcus.folkesson@gmail.com> (raw)
In-Reply-To: <1321969191-8604-1-git-send-email-marcus.folkesson@gmail.com>
The function is not actually cleaing the bitmask.
Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
---
drivers/mfd/tps65910.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c
index 6f5b8cf..c1da84b 100644
--- a/drivers/mfd/tps65910.c
+++ b/drivers/mfd/tps65910.c
@@ -120,7 +120,7 @@ int tps65910_clear_bits(struct tps65910 *tps65910, u8 reg, u8 mask)
goto out;
}
- data &= mask;
+ data &= ~mask;
err = tps65910_i2c_write(tps65910, reg, 1, &data);
if (err)
dev_err(tps65910->dev, "write to reg %x failed\n", reg);
--
1.7.5.4
next prev parent reply other threads:[~2011-11-22 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Marcus Folkesson <marcus.folkesson@gmail.com>
2011-11-22 13:39 ` [PATCH] mfd: tps65910: Handle clear-mask correctly desc Marcus Folkesson
2011-11-22 13:39 ` Marcus Folkesson [this message]
2011-12-12 14:30 ` [PATCH] mfd: tps65910: Handle clear-mask correctly Samuel Ortiz
2011-12-12 15:04 ` Graeme Gregory
2013-11-22 7:16 ` [PATCH RESEND] rtc: ds1511: add device-tree bindings Marcus Folkesson
2013-11-22 7:16 ` [PATCH] " Marcus Folkesson
2013-11-22 9:26 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321969191-8604-2-git-send-email-marcus.folkesson@gmail.com \
--to=marcus.folkesson@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox