From: John Stultz <john.stultz@linaro.org>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
Rabin Vincent <rabin.vincent@stericsson.com>,
stable@kernel.org
Subject: Re: [PATCH] rtc: disable the alarm in the hardware
Date: Tue, 22 Nov 2011 12:32:04 -0800 [thread overview]
Message-ID: <1321993924.6445.74.camel@work-vm> (raw)
In-Reply-To: <1321956194-8382-1-git-send-email-linus.walleij@stericsson.com>
On Tue, 2011-11-22 at 11:03 +0100, Linus Walleij wrote:
> From: Rabin Vincent <rabin.vincent@stericsson.com>
>
> Currently, the RTC code does not disable the alarm in the hardware.
>
> This means that after a sequence such as the one below (the files are in the
> RTC sysfs), the box will boot up after 2 minutes even though we've
> asked for the alarm to be turned off.
>
> # echo $((`cat since_epoch`)+120) > wakealarm
> # echo 0 > wakealarm
> # poweroff
>
> Fix this by disabling the alarm when there are no timers to run.
Hey Linus,
Thanks for sending this along! It looks like a good fix to me! I'm a
little amazed this hasn't cropped up sooner. I'll do some further
testing and then queue it for upstream.
thanks
-john
next prev parent reply other threads:[~2011-11-22 20:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 10:03 [PATCH] rtc: disable the alarm in the hardware Linus Walleij
2011-11-22 20:32 ` John Stultz [this message]
2011-11-23 12:53 ` [rtc-linux] " Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321993924.6445.74.camel@work-vm \
--to=john.stultz@linaro.org \
--cc=a.zummo@towertech.it \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin.vincent@stericsson.com \
--cc=rtc-linux@googlegroups.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox