Re: [PATCH v4 0/2] nfs/sunrpc: allow freezing of tasks with NFS calls in flight

Adam Williamson
2011-12-01T19:32:45Z

On Thu, 2011-12-01 at 10:49 -0800, Tejun Heo wrote:
> On Wed, Nov 30, 2011 at 08:43:13PM +0100, Rafael J. Wysocki wrote:
> > On Tuesday, November 29, 2011, Jeff Layton wrote:
> > > This patchset is the fourth attempt at fixing the issues with suspending
> > > a machine that has an active NFS mount.
> > >
> > > The bug reported against Fedora is here:
> > >
> > > https://bugzilla.redhat.com/show_bug.cgi?id=717735
> > >
> > > The main difference from v3 is that I've fixed a stupid set of errors in
> > > freezable_schedule_timeout_killable. The if condition was reversed from
> > > what it should have been, and the code did not call freezer_count()
> > > again when it was going to return early.
> > >
> > > Tejun has mentioned that the extra try_to_freeze() calls are unnecessary
> > > on top of the pm-freezer changes, but this set should work on as
> > > expected on top of 3.2-ish kernels. In the meantime, I'll look over the
> > > pm-freezer changes and see whether I need to make changes in this set
> > > for 3.3.
> > >
> > > Jeff Layton (2):
> > > sunrpc: make rpc_wait_bit_killable handle freeze events
> > > nfs: make TASK_KILLABLE sleeps attempt to freeze
> >
> > Both patches applied to linux-pm/linux-next. I'll move them to
> > linux-pm/pm-freezer in a couple of days if there are no problems with
> > them.
>
> Rafael, I think the extra try_to_freeze() is actually incorrect on top
> of pm-freezer. Jeff, can you please remove that?

You might want to read two levels up: Jeff explicitly mentioned that
already. :)
--
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | identi.ca: adamwfedora