From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756129Ab1K3IRL (ORCPT ); Wed, 30 Nov 2011 03:17:11 -0500 Received: from www17.your-server.de ([213.133.104.17]:40631 "EHLO www17.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522Ab1K3IRH (ORCPT ); Wed, 30 Nov 2011 03:17:07 -0500 Subject: [PATCH] mm: Use kcalloc instead of kzalloc to allocate array From: Thomas Meyer To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Date: Tue, 29 Nov 2011 22:08:00 +0100 Message-ID: <1322600880.1534.349.camel@localhost.localdomain> X-Mailer: Evolution 3.2.2 (3.2.2-1.fc16) Content-Transfer-Encoding: 7bit X-Authenticated-Sender: thomas@m3y3r.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. The semantic patch that makes this change is available in https://lkml.org/lkml/2011/11/25/107 Signed-off-by: Thomas Meyer --- diff -u -p a/mm/vmalloc.c b/mm/vmalloc.c --- a/mm/vmalloc.c 2011-11-28 19:36:48.210120310 +0100 +++ b/mm/vmalloc.c 2011-11-28 20:06:49.925235983 +0100 @@ -2348,8 +2348,8 @@ struct vm_struct **pcpu_get_vm_areas(con return NULL; } - vms = kzalloc(sizeof(vms[0]) * nr_vms, GFP_KERNEL); - vas = kzalloc(sizeof(vas[0]) * nr_vms, GFP_KERNEL); + vms = kcalloc(nr_vms, sizeof(vms[0]), GFP_KERNEL); + vas = kcalloc(nr_vms, sizeof(vas[0]), GFP_KERNEL); if (!vas || !vms) goto err_free;