From: Peter Zijlstra <peterz@infradead.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jason Baron <jbaron@redhat.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@linux.intel.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Paul Turner <pjt@google.com>
Subject: Re: Perhaps a side effect regarding NMI returns
Date: Wed, 30 Nov 2011 12:56:08 +0100 [thread overview]
Message-ID: <1322654168.2921.257.camel@twins> (raw)
In-Reply-To: <1322607086.17003.94.camel@frodo>
On Tue, 2011-11-29 at 17:51 -0500, Steven Rostedt wrote:
> static void run_sync(void)
> {
> int enable_irqs = irqs_disabled();
>
> /* We may be called with interrupts disbled. */
> if (enable_irqs)
> local_irq_enable();
> on_each_cpu(do_sync_core, NULL, 1);
> if (enable_irqs)
> local_irq_disable();
> }
>
> Note, it's fine to enable interrupts here, it's only used by ftrace.
Still ugly as hell though, why not push that pain to the caller?
next prev parent reply other threads:[~2011-11-30 11:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 4:07 Perhaps a side effect regarding NMI returns Steven Rostedt
2011-11-29 4:53 ` Linus Torvalds
2011-11-29 7:33 ` Paul Turner
2011-11-29 20:09 ` Andi Kleen
2011-11-29 20:12 ` Linus Torvalds
2011-11-29 20:31 ` Andi Kleen
2011-11-29 20:36 ` Linus Torvalds
2011-11-29 20:58 ` Steven Rostedt
2011-11-29 21:05 ` Linus Torvalds
2011-11-29 21:22 ` Steven Rostedt
2011-11-29 22:14 ` Jason Baron
2011-11-29 22:51 ` Steven Rostedt
2011-11-30 11:56 ` Peter Zijlstra [this message]
2011-11-29 20:35 ` Steven Rostedt
2011-11-29 20:44 ` Linus Torvalds
2011-12-07 16:36 ` Steven Rostedt
2011-12-07 16:44 ` Linus Torvalds
2011-12-07 17:31 ` Steven Rostedt
2011-12-07 17:48 ` Linus Torvalds
2011-12-07 17:51 ` Andi Kleen
2012-01-08 8:55 ` [tip:perf/core] x86: Do not schedule while still in NMI context tip-bot for Linus Torvalds
2011-11-29 21:28 ` Perhaps a side effect regarding NMI returns Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322654168.2921.257.camel@twins \
--to=peterz@infradead.org \
--cc=andi@firstfloor.org \
--cc=fweisbec@gmail.com \
--cc=hpa@linux.intel.com \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@redhat.com \
--cc=pjt@google.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox