From: Mike Galbraith <efault@gmx.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
RT <linux-rt-users@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
"Luis Claudio R. Goncalves" <lclaudio@uudg.org>,
Clark Williams <williams@redhat.com>
Subject: Re: [PATCH RT] tasklet/rt: Prevent tasklets from going into infinite spin in RT
Date: Wed, 30 Nov 2011 14:04:35 +0100 [thread overview]
Message-ID: <1322658275.5297.17.camel@marge.simson.net> (raw)
In-Reply-To: <1322657130.5297.12.camel@marge.simson.net>
On Wed, 2011-11-30 at 13:45 +0100, Mike Galbraith wrote:
> On Wed, 2011-11-30 at 11:24 +0100, Thomas Gleixner wrote:
> > On Wed, 30 Nov 2011, Mike Galbraith wrote:
> > > @@ -131,11 +155,18 @@ void softirq_check_pending_idle(void)
> > > */
> > > static void wakeup_softirqd(void)
> > > {
> > > - /* Interrupts are disabled: no need to stop preemption */
> > > - struct task_struct *tsk = __this_cpu_read(ksoftirqd);
> > > + struct task_struct *tsk;
> > > + u32 pending = local_softirq_pending(), mask, i;
> > >
> > > - if (tsk && tsk->state != TASK_RUNNING)
> > > - wake_up_process(tsk);
> > > + /* Interrupts are disabled: no need to stop preemption */
> > > + for (i = 0; pending && i < NR_SOFTIRQ_THREADS; i++) {
> > > + mask = __get_cpu_var(ksoftirqd)[i].mask;
> > > + if (!(pending & mask))
> > > + continue;
> > > + tsk = __get_cpu_var(ksoftirqd)[i].tsk;
> > > + if (tsk && tsk->state != TASK_RUNNING)
> > > + wake_up_process(tsk);
> > > + }
> > > }
> >
> > Dammned serious is seems. :)
'course here I should have just used the busy bits directly.
-Mike
next prev parent reply other threads:[~2011-11-30 13:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 1:55 [PATCH RT] tasklet/rt: Prevent tasklets from going into infinite spin in RT Steven Rostedt
2011-11-30 3:50 ` Clark Williams
2011-11-30 6:24 ` Mike Kravetz
2011-11-30 15:56 ` Mike Kravetz
2011-11-30 4:32 ` Mike Galbraith
2011-11-30 7:34 ` Mike Galbraith
2011-11-30 10:24 ` Thomas Gleixner
2011-11-30 12:45 ` Mike Galbraith
2011-11-30 13:04 ` Mike Galbraith [this message]
2011-12-01 9:12 ` PATCH RT] resurrect softirq threads for RT_FULL Mike Galbraith
2011-11-30 8:46 ` [PATCH RT] tasklet/rt: Prevent tasklets from going into infinite spin in RT Tim Sander
2011-11-30 14:24 ` Luis Claudio R. Goncalves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322658275.5297.17.camel@marge.simson.net \
--to=efault@gmx.de \
--cc=lclaudio@uudg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox