From: Peter Zijlstra <peterz@infradead.org>
To: Jerome Marchand <jmarchan@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Nitin Gupta <ngupta@vflare.org>,
Robert Jennings <rcj@linux.vnet.ibm.com>,
Witold Baryluk <baryluk@smp.if.uj.edu.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] Staging: zram: Turn lockdep off during zram_init_device()
Date: Wed, 30 Nov 2011 14:59:04 +0100 [thread overview]
Message-ID: <1322661544.2921.274.camel@twins> (raw)
In-Reply-To: <4ED62C38.1020106@redhat.com>
On Wed, 2011-11-30 at 14:14 +0100, Jerome Marchand wrote:
> zram->init_lock can be hold over an allocation that may try to reclaim
> memory in zram_init_device(). The same lock can later be taken from a
> reclaim context in zram_make_request(), thus triggering a lockdep
> warning. However, memory can not be reclaimed to an uninitialized zram
> device. Therefore, this warning is a false positive.
> To prevent the warning to occur, we turn lockdep off during while the
> device is initialized.
fuck no! why do you even remotely consider this a sane thing to do?
There's tons of lockdep annotations, try one of those. If you have, your
changelog utterly fails to explain why non of those are suitable and how
your problem is special.
next prev parent reply other threads:[~2011-11-30 13:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 13:14 [PATCH 1/2] Staging: zram: Turn lockdep off during zram_init_device() Jerome Marchand
2011-11-30 13:16 ` [PATCH 2/2] Staging: zram: Add a missing GFP_KERNEL specifier in zram_init_device() Jerome Marchand
2011-11-30 13:59 ` Peter Zijlstra [this message]
2011-12-03 17:38 ` [PATCH 1/2] Staging: zram: Turn lockdep off during zram_init_device() Witold Baryluk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322661544.2921.274.camel@twins \
--to=peterz@infradead.org \
--cc=baryluk@smp.if.uj.edu.pl \
--cc=gregkh@suse.de \
--cc=jmarchan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngupta@vflare.org \
--cc=rcj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox