From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754915Ab1LAWKf (ORCPT ); Thu, 1 Dec 2011 17:10:35 -0500 Received: from merlin.infradead.org ([205.233.59.134]:39495 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754638Ab1LAWKe convert rfc822-to-8bit (ORCPT ); Thu, 1 Dec 2011 17:10:34 -0500 Message-ID: <1322777407.4699.59.camel@twins> Subject: Re: [PATCH 09/11] sched: export task_prio to GPL modules From: Peter Zijlstra To: Mathieu Desnoyers Cc: Greg KH , devel@driverdev.osuosl.org, lttng-dev@lists.lttng.org, Ingo Molnar , linux-kernel@vger.kernel.org, Darren Hart Date: Thu, 01 Dec 2011 23:10:07 +0100 In-Reply-To: <20111201220445.GA10552@Krystal> References: <1322775683-8741-1-git-send-email-mathieu.desnoyers@efficios.com> <1322775683-8741-10-git-send-email-mathieu.desnoyers@efficios.com> <1322776568.4699.52.camel@twins> <20111201220445.GA10552@Krystal> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Evolution 3.2.1- Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2011-12-01 at 17:04 -0500, Mathieu Desnoyers wrote: > * Peter Zijlstra (peterz@infradead.org) wrote: > > On Thu, 2011-12-01 at 16:41 -0500, Mathieu Desnoyers wrote: > > > LTTng needs this symbol to prepend the current task dynamic priority > > > value to events (optional context information). > > > > I absolutely detest exporting such stuff. It propagates the idea that > > task prio actually means something. Also, modules really shouldn't care. > > People debugging their SCHED_FIFO/SCHED_RR applications, as well as > users of priority-inheritance futexes, may happen to find this > information extremely useful. > > Just saying... Right until the moment we go do deadlines.. Anyway, it still doesn't make sense, your sched_switch() tracepoint handler gets this information, why do you need this export at all?