Re: [PATCH 01/11] mm: export vmalloc_sync_all symbol to GPL modules

Christoph Hellwig
2011-12-01T22:28:16Z

On Thu, Dec 01, 2011 at 02:13:37PM -0800, Greg KH wrote:
> On Thu, Dec 01, 2011 at 04:57:00PM -0500, Christoph Hellwig wrote:
> > On Thu, Dec 01, 2011 at 04:41:13PM -0500, Mathieu Desnoyers wrote:
> > > LTTng needs this symbol exported. It calls it to ensure its tracing
> > > buffers and allocated data structures never trigger a page fault. This
> > > is required to handle page fault handler tracing and NMI tracing
> > > gracefully.
> >
> > We:
> >
> > a) don't export symbols unless they have an intree-user
>
> lttng is now in-tree in the drivers/staging/ area. See linux-next for
> details if you are curious.

Eww - merging stuff without discussion on lkml is more than evil.

Either way, it was guaranteed that drivers/staging is considered out of
tree for core code. I'm defintively dead set against exporting anything
for staging and opening that slippery slope.