From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
rostedt@goodmis.org
Subject: Re: [PATCH] jump_label: jump_label for boot options.
Date: Fri, 02 Dec 2011 13:53:27 +0100 [thread overview]
Message-ID: <1322830407.2822.6.camel@laptop> (raw)
In-Reply-To: <20111202124558.GB1295@cmpxchg.org>
On Fri, 2011-12-02 at 13:45 +0100, Johannes Weiner wrote:
> On Fri, Dec 02, 2011 at 10:24:10AM +0100, Peter Zijlstra wrote:
> > On Fri, 2011-12-02 at 09:22 +0900, KAMEZAWA Hiroyuki wrote:
> > >
> > > Yes, that's an idea. But we also have another stupid shadow swap accounting
> > > table. This can be disabled at boot, too.
> >
> > Bah I thought it was just the page frame thing, hnaz any plans to kill
> > this swap array as well?
>
> I haven't looked at the swap accounting at all yet, sorry. But where
> did this discussion go all of a sudden? :-)
>
> That array is not allocated at all when the memory controller is
> disabled at boot-time.
>
> Rather, we have those mem_cgroup_disabled() conditionals everytime we
> enter the memory controller from the VM and the idea is to patch them
> out during boot, since you can not re-enable the thing anyway.
Yeah, but without those arrays you could.. this boot time switch really
is a wart and if you don't have the shadow page frame and shadow swap
accounting muck stuff you could runtime flip all this..
I've no objection to using jump_labels fwiw, we're looking to do the
same with the cpu controller for the nr_cgroups == 0 case. But boot time
stuff just doesn't make sense to me.
next prev parent reply other threads:[~2011-12-02 12:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-01 2:53 [PATCH] jump_label: jump_label for boot options KAMEZAWA Hiroyuki
2011-12-01 14:48 ` Steven Rostedt
2011-12-01 15:06 ` Peter Zijlstra
2011-12-01 16:14 ` Steven Rostedt
2011-12-01 15:07 ` Peter Zijlstra
2011-12-02 0:18 ` KAMEZAWA Hiroyuki
2011-12-01 15:05 ` Peter Zijlstra
2011-12-02 0:22 ` KAMEZAWA Hiroyuki
2011-12-02 9:24 ` Peter Zijlstra
2011-12-02 12:45 ` Johannes Weiner
2011-12-02 12:53 ` Peter Zijlstra [this message]
2011-12-07 10:16 ` Johannes Weiner
2011-12-01 15:40 ` Jason Baron
2011-12-01 16:28 ` Peter Zijlstra
2011-12-01 16:50 ` Jason Baron
2011-12-01 17:16 ` Jason Baron
2011-12-01 18:16 ` Peter Zijlstra
2011-12-01 17:39 ` Peter Zijlstra
2011-12-01 17:45 ` Peter Zijlstra
2011-12-01 21:13 ` Jason Baron
2011-12-01 22:08 ` Peter Zijlstra
2011-12-02 0:28 ` KAMEZAWA Hiroyuki
2011-12-02 5:34 ` Mike Galbraith
2011-12-02 5:47 ` KAMEZAWA Hiroyuki
2011-12-02 8:39 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322830407.2822.6.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=hannes@cmpxchg.org \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox