Re: [PATCH] ata: Don't use NO_IRQ in pata_of_platform driver

Dave Martin
2011-12-06T11:37:45Z

On Tue, Dec 06, 2011 at 10:46:54AM +0000, Russell King - ARM Linux wrote:
> On Tue, Dec 06, 2011 at 09:37:09AM +0000, Dave Martin wrote:
> > To clarify, you're suggesting that the meanings of all other IRQ values
> > would not change initially? (i.e., we remap HW irq 0, if there is one,
> > to some other random number but have a 1:1 mapping for everything else).
>
> Even better. Avoid the first 16 IRQ numbers altogether - so that ISA
> drivers which have these numbers hard-encoded in them will see failures
> if they're expecting standard ISA IRQ numbering.
>
> We already do that with the GIC, partly because of the hardware design.
> We do that on Footbridge based systems, because they may or may not have
> a real ISA IRQ controller.
>
> But.. let's make one thing clear: Alan Cox and Linus have been going on
> about how IRQ0 should not be used. Let's be crystal clear: even x86
> uses IRQ0. It happens to be the PIC timer, and that gets claimed early
> on during the x86 boot. So please don't tell me that x86 avoids IRQ0.
> It doesn't. It just happens that x86 never shows IRQ0 to anything but
> the i8253 PIC driver.
>
> So lets see how x86 squeels if we make the i8253 PIC driver reject IRQ0.
> I bet that there'd be absolute fury at such a suggestion.
>
> When x86 sorts this out, there _might_ be some more motivation to take
> such comments seriously. Until then it's more like a joke.

OK -- but the situation is breaking OF-based drivers on ARM platforms
today.

Based on what you've suggested, does the following policy sound
reasonable for resolving that deadlock?

1) All OF code and drivers should be migrating to use 0 instead of NO_IRQ
for the no-interrupt case. Code which receives irq numbers directly
from the OF framework and refers to NO_IRQ, or expects 0 to be a valid
needs to be fixed.

2) Where we hit a problem, board code needs to be adapted to remap HW IRQs
0-15 to different software values. (This could be done using irq
domains, or not)

I'm still not sure what the correct approach is for drivers which get
irq numbers from OF indirectly -- this particularly applies to platform
and AMBA devices.

If we expect board code to start populating platform data based on
information from the OF code, we need to fix the board not to use linux
irq 0 to describe a real HW interrupt, if it matters (as in (2)).

AMBA devices registered via of_platform_populate() already get their
irq numbers from OF. So long as OF used to explicitly return NO_IRQ
there was no problem -- but if OF is moving to return 0 instead, we have
a potential problem for each AMBA driver which may be used by a board
which can boot without DT... if we have any scenarios where that driver
is given real irq 0.

Maybe we can fix these breakages as they occur -- I don't really know
the scale of the impact.

What are your thoughts on this?

Cheers
---Dave