From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Myron Stowe <myron.stowe@redhat.com>,
linux-pci@vger.kernel.org, linux@arm.linux.org.uk,
vapier@gentoo.org, dhowells@redhat.com,
ysato@users.sourceforge.jp, tony.luck@intel.com,
fenghua.yu@intel.com, monstr@monstr.eu, ralf@linux-mips.org,
paulus@samba.org, lethal@linux-sh.org, davem@davemloft.net,
cmetcalf@tilera.com, gxt@mprc.pku.edu.cn, tglx@linutronix.de,
mingo@redhat.com, chris@zankel.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -v2 01/16] PCI: add declaration for pcibios_set_master() to pci core
Date: Tue, 06 Dec 2011 07:32:37 +1100 [thread overview]
Message-ID: <1323117157.660.22.camel@pasglop> (raw)
In-Reply-To: <20111205110639.479a6e8e@jbarnes-desktop>
On Mon, 2011-12-05 at 11:06 -0800, Jesse Barnes wrote:
> On Fri, 28 Oct 2011 15:47:35 -0600
> Myron Stowe <myron.stowe@redhat.com> wrote:
>
> > From: Myron Stowe <mstowe@redhat.com>
> >
> > Currently, pcibios_set_master() is implemented in architecture-
> > specific code. There is nothing architecture-specific about PCI's
> > 'latency timer'.
> >
> > This patch adds a declaration for pcibios_set_master() to PCI's core
> > in preperation for pulling the function itself up into the core.
> > Without the addition of this declaration, subsequent patches that
> > remove inline definitions of pcibios_set_master() would be removing
> > the only declaration of such.
> >
> > No functional change.
> >
> > Signed-off-by: Myron Stowe <myron.stowe@redhat.com>
> > ---
>
> Ok this series is in -next. Let's see what breaks this time. :)
On the other hand...
One thing that annoys the sh*it out of me is that I cannot use
pcibios_set_master() to establish the DMA/iommu resources for a device,
because set_dma_mask() will be called -after- set_master(), thus I need
to provision every device with 32-bit DMA resources (which can be quite
scarse) just in case the driver doesn't later call set_dma_mask(64-bit).
If only we could reverse the call order... lots of drivers to fix
unfortunately.
In which case I -would- hook into pcibios_set_master()...
Cheers,
Ben.
next prev parent reply other threads:[~2011-12-05 20:33 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 21:47 [PATCH -v2 00/16] PCI: Re-factor PCI's 'latency timer' setup Myron Stowe
2011-10-28 21:47 ` [PATCH -v2 01/16] PCI: add declaration for pcibios_set_master() to pci core Myron Stowe
2011-12-05 19:06 ` Jesse Barnes
2011-12-05 20:32 ` Benjamin Herrenschmidt [this message]
2011-10-28 21:47 ` [PATCH -v2 02/16] PCI: ARM: convert pcibios_set_master() to a non-inlined function Myron Stowe
2011-10-28 21:47 ` [PATCH -v2 03/16] PCI: IA64: " Myron Stowe
2011-10-28 21:47 ` [PATCH -v2 04/16] PCI: MicroBlaze: " Myron Stowe
2011-10-28 21:48 ` [PATCH -v2 05/16] PCI: PowerPC: " Myron Stowe
2011-10-28 21:48 ` [PATCH -v2 06/16] PCI: SPARC: " Myron Stowe
2011-10-28 21:48 ` [PATCH -v2 07/16] PCI: TILE: " Myron Stowe
2011-10-31 15:27 ` Chris Metcalf
2011-10-28 21:48 ` [PATCH -v2 08/16] PCI: UniCore: " Myron Stowe
2011-10-28 21:48 ` [PATCH -v2 09/16] PCI: Xtensa: " Myron Stowe
2011-10-28 21:48 ` [PATCH -v2 10/16] PCI: Pull PCI 'latency timer' setup up into the core Myron Stowe
2011-10-28 21:48 ` [PATCH -v2 11/16] PCI: frv: use generic pcibios_set_master() Myron Stowe
2011-10-28 21:48 ` [PATCH -v2 12/16] PCI: MIPS: " Myron Stowe
2011-10-28 21:48 ` [PATCH -v2 13/16] PCI: mn10300: " Myron Stowe
2011-10-28 21:49 ` [PATCH -v2 14/16] PCI: sh: " Myron Stowe
2011-10-28 21:49 ` [PATCH -v2 15/16] PCI: x86: " Myron Stowe
2011-10-28 21:49 ` [PATCH -v2 16/16] PCI: latency timer doesn't apply to PCIe Myron Stowe
2011-10-29 0:46 ` [PATCH -v2 00/16] PCI: Re-factor PCI's 'latency timer' setup Mike Frysinger
2011-10-31 16:08 ` Myron Stowe
2011-10-31 23:14 ` Myron Stowe
2011-11-11 17:59 ` Jesse Barnes
2011-11-15 22:43 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323117157.660.22.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=chris@zankel.net \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=gxt@mprc.pku.edu.cn \
--cc=jbarnes@virtuousgeek.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=myron.stowe@redhat.com \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vapier@gentoo.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox