From: Rhyland Klein <rklein@nvidia.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>
Subject: Re: [PATCH 2/5] power: sbs-battery: rename internals to new name
Date: Mon, 05 Dec 2011 17:20:10 -0800 [thread overview]
Message-ID: <1323134410.24760.1.camel@rklein-linux2> (raw)
In-Reply-To: <20111206012012.GA3065@oksana.dev.rtsoft.ru>
On Mon, 2011-12-05 at 17:20 -0800, Anton Vorontsov wrote:
> On Mon, Dec 05, 2011 at 03:58:04PM -0800, Rhyland Klein wrote:
> [...]
> > -static const struct i2c_device_id bq20z75_id[] = {
> > - { "bq20z75", 0 },
> > +static const struct i2c_device_id sbs_id[] = {
> > + { "sbs-battery", 0 },
>
> You have to leave "bq20z75" here as is, and add "sbs-battery" as an
> additional device id.
>
> The reason is that older device trees might already have compatible
> = "bq20z75", without specifying "sbs-battery".
>
> Thanks!
>
Good thought! I had thought about that at some point but apparently not
when actually working on the patch. Will do in v2.
-rhyland
next prev parent reply other threads:[~2011-12-06 1:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 23:58 [PATCH 1/5] drivers: power: Rename bq20z75 to sbs-battery Rhyland Klein
2011-12-05 23:58 ` [PATCH 2/5] power: sbs-battery: rename internals to new name Rhyland Klein
2011-12-06 1:20 ` Anton Vorontsov
2011-12-06 1:20 ` Rhyland Klein [this message]
2011-12-05 23:58 ` [PATCH 3/5] Adding entry for Smart Battery Systems Rhyland Klein
2011-12-05 23:58 ` [PATCH 4/5] Rename propgated to dt binding documentation Rhyland Klein
2011-12-05 23:58 ` [PATCH 5/5] power: sbs-battery: Change power supply name Rhyland Klein
2011-12-06 1:33 ` Anton Vorontsov
2011-12-06 17:41 ` [PATCH 1/5] drivers: power: Rename bq20z75 to sbs-battery Matthew Garrett
2011-12-14 19:26 ` Rhyland Klein
2011-12-14 19:51 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323134410.24760.1.camel@rklein-linux2 \
--to=rklein@nvidia.com \
--cc=cbouatmailru@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox