From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Jason Baron <jbaron@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Mike Galbraith <efault@gmx.de>,
Paul Turner <pjt@google.com>,
Arnaldo Carvalho de Melo <acme@infradead.org>
Subject: Re: [PATCH 0/3] Use jump_label for sched_feat()
Date: Tue, 06 Dec 2011 20:12:00 +0100 [thread overview]
Message-ID: <1323198720.32012.84.camel@twins> (raw)
In-Reply-To: <20111206181000.GE2449@redhat.com>
On Tue, 2011-12-06 at 13:10 -0500, Jason Baron wrote:
> On Tue, Dec 06, 2011 at 06:15:34PM +0100, Peter Zijlstra wrote:
> > These patches implement sched_feat() using jump_labels. The first is a section
> > mismatch fix. The second patch provides a little infrastructure and the third
> > patch applies it to make sched_feat() use static_branch().
> >
> > It uses static_branch() coupled with unlikely/likely in order to control the
> > branch block position. I haven't checked if it works, but it likely doesn't,
> > although it should.
> >
> >
>
> It doesn't. I played around with unlikely/likely a bit, and it
> didn't seem to make a difference.
Right, we should look at getting that fixed though.. I think its a very
useful hint to have.
> That said, jump_labels could still be
> an improvement here - it be good if we had some numbers, I guess.
Yeah, acme had some number on an older version of this patch.
prev parent reply other threads:[~2011-12-06 19:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-06 17:15 [PATCH 0/3] Use jump_label for sched_feat() Peter Zijlstra
2011-12-06 17:15 ` [PATCH 1/3] jump_label, x86: Fix section mismatch Peter Zijlstra
2011-12-06 17:15 ` [PATCH 2/3] sched: Fix compile error for UP,!NOHZ Peter Zijlstra
2011-12-06 17:35 ` Peter Zijlstra
2011-12-06 17:15 ` [PATCH 3/3] sched: Use jump_labels for sched_feat Peter Zijlstra
2011-12-06 18:10 ` [PATCH 0/3] Use jump_label for sched_feat() Jason Baron
2011-12-06 19:12 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323198720.32012.84.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=acme@infradead.org \
--cc=efault@gmx.de \
--cc=jbaron@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pjt@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox