From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756221Ab1LGOZO (ORCPT ); Wed, 7 Dec 2011 09:25:14 -0500 Received: from mail-ee0-f46.google.com ([74.125.83.46]:39075 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755798Ab1LGOZM (ORCPT ); Wed, 7 Dec 2011 09:25:12 -0500 Message-ID: <1323267891.4009.16.camel@lappy> Subject: Re: [PATCH 1/2] KVM: VMX: Notify if VMX is already in use From: Sasha Levin To: Avi Kivity Cc: linux-kernel@vger.kernel.org, Joerg Roedel , Marcelo Tosatti , kvm@vger.kernel.org Date: Wed, 07 Dec 2011 16:24:51 +0200 In-Reply-To: <4EDF76D6.7020800@redhat.com> References: <1322764218-4698-1-git-send-email-levinsasha928@gmail.com> <4EDF7590.5060701@redhat.com> <1323267521.4009.11.camel@lappy> <4EDF76D6.7020800@redhat.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.2.2 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2011-12-07 at 16:23 +0200, Avi Kivity wrote: > On 12/07/2011 04:18 PM, Sasha Levin wrote: > > On Wed, 2011-12-07 at 16:17 +0200, Avi Kivity wrote: > > > On 12/01/2011 08:30 PM, Sasha Levin wrote: > > > > Currently we silently fail if VMX is already in use by a different > > > > virtualization technology. > > > > > > > > This is bad since it's non-obvious for the user, and its not too uncommon > > > > for users to have several of these installed on same host. > > > > > > > > This patch adds a message to notify the user of the problem. > > > > > > > > > > Does this actually happen? With which hypervisor? > > > > vbox > > > > It turns VMX/SVM on when it loads, regardless of whether it's running a > > guest or not. > > That's odd. IIRC when we discussed this with them, they were executing > VMXON/VMXOFF dynamically. Looks like they changed this. > > Anyway, please adjust according to Joerg's comment (and add the word > "using"), and I'll apply. I've seen it the day before I've sent those patches. vbox driver loaded, kvm silently failed and rdmsr showed SVME turned on. Will resend. -- Sasha.