From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756555Ab1LGOmd (ORCPT ); Wed, 7 Dec 2011 09:42:33 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:50967 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755798Ab1LGOmc (ORCPT ); Wed, 7 Dec 2011 09:42:32 -0500 Message-ID: <1323268930.4009.19.camel@lappy> Subject: Re: [PATCH 1/2] KVM: VMX: Notify if VMX is already in use From: Sasha Levin To: Avi Kivity Cc: linux-kernel@vger.kernel.org, Joerg Roedel , Marcelo Tosatti , kvm@vger.kernel.org Date: Wed, 07 Dec 2011 16:42:10 +0200 In-Reply-To: <4EDF7797.9080103@redhat.com> References: <1322764218-4698-1-git-send-email-levinsasha928@gmail.com> <4EDF7590.5060701@redhat.com> <1323267521.4009.11.camel@lappy> <4EDF76D6.7020800@redhat.com> <1323267891.4009.16.camel@lappy> <4EDF7797.9080103@redhat.com> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.2.2 Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2011-12-07 at 16:26 +0200, Avi Kivity wrote: > On 12/07/2011 04:24 PM, Sasha Levin wrote: > > > > > > That's odd. IIRC when we discussed this with them, they were executing > > > VMXON/VMXOFF dynamically. Looks like they changed this. > > > > > > Anyway, please adjust according to Joerg's comment (and add the word > > > "using"), and I'll apply. > > > > I've seen it the day before I've sent those patches. vbox driver loaded, > > kvm silently failed and rdmsr showed SVME turned on. > > > > Will resend. > > Ah, maybe they do it differently on AMD. Or they changed things. > > btw, was it really silent? Didn't modprobe complain? > > The patch makes sense in any case. Not totally silent, there was an error about KVM failing to enable hardware virtualization, but it was generic and didn't really point to the problem. -- Sasha.