The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Tejun Heo <tj@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: workqueue_set_max_active(wq, 0)?
Date: Fri, 09 Dec 2011 10:54:42 +0100	[thread overview]
Message-ID: <1323424482.3622.8.camel@jlt3.sipsolutions.net> (raw)

Hi,

I know workqueue_set_max_active(wq, 0) isn't allowed, but I was just
playing with making mac80211 completely synchronous in the configuration
path. (The reason is that right now, we have a single-threaded workqueue
and configuration entry points, so it's *almost* single-threaded /
synchronous. This means that the non-synchronous nature rarely gets
tested.)

So I thought I could put a work struct onto the workqueue and then when
it executes it signals the configuration function & waits for that to
finish, etc., a bit like the rendezvous mechanism used to flush works.

But then I thought maybe this should be more generic, like
"workqueue_pause()" / "workqueue_resume()".

And then I found workqueue_set_max_active() but passing 0 isn't allowed.

Before I dive in more deeply I figured I'd ask if you think what a good
way of doing this would be (and whether I'm completely insane) :-)

johannes


             reply	other threads:[~2011-12-09  9:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-09  9:54 Johannes Berg [this message]
2011-12-09 16:57 ` workqueue_set_max_active(wq, 0)? Tejun Heo
2011-12-09 16:59   ` Johannes Berg
2011-12-15 15:38   ` Johannes Berg
2011-12-15 18:35     ` Tejun Heo
2011-12-15 18:43       ` Johannes Berg
2011-12-15 19:12         ` Tejun Heo
2011-12-15 19:26           ` Johannes Berg
2011-12-15 19:31             ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323424482.3622.8.camel@jlt3.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox