From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Ming Lei <tom.leiming@gmail.com>
Cc: gregkh@suse.de, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, ostrikov@nvidia.com,
adobriyan@gmail.com, eric.dumazet@gmail.com, mingo@elte.hu,
Oliver Neukum <oneukum@suse.de>
Subject: Re: [PATCH 3/3] kref: Remove the memory barriers
Date: Sun, 11 Dec 2011 16:35:38 +0100 [thread overview]
Message-ID: <1323617738.16764.21.camel@twins> (raw)
In-Reply-To: <CACVXFVOYj+Mmph8WGQUdcGS8t-GPr9y3crPuz0SrBCtOmCvstQ@mail.gmail.com>
On Sun, 2011-12-11 at 20:59 +0800, Ming Lei wrote:
>
> The implicit rule about kref is that use should make sure
> that kref can not be touched once it is released.
The only transition for with order makes any difference what so ever is
1 -> 0, you just said that should be done by external means (I agree and
have argued thusly), therefore any memory barriers outside of these
external means are superfluous.
Thus the proposed patch is correct.
next prev parent reply other threads:[~2011-12-11 15:36 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 10:43 [PATCH 0/3] kref: inline and barriers Peter Zijlstra
2011-12-10 10:43 ` [PATCH 1/3] kref: Inline all functions Peter Zijlstra
2011-12-10 14:32 ` Ming Lei
2011-12-10 14:59 ` Peter Zijlstra
2011-12-12 22:11 ` Greg KH
2011-12-13 9:36 ` Peter Zijlstra
2011-12-13 17:15 ` Greg KH
2011-12-13 18:52 ` Peter Zijlstra
2011-12-13 19:11 ` Greg KH
2011-12-13 19:36 ` Peter Zijlstra
2011-12-10 10:43 ` [PATCH 2/3] kref: Implement kref_put in terms of kref_sub Peter Zijlstra
2011-12-10 10:43 ` [PATCH 3/3] kref: Remove the memory barriers Peter Zijlstra
2011-12-10 14:07 ` Ming Lei
2011-12-10 14:58 ` Peter Zijlstra
2011-12-10 15:57 ` Ming Lei
2011-12-10 19:49 ` Peter Zijlstra
2011-12-11 2:22 ` Ming Lei
2011-12-11 12:47 ` Peter Zijlstra
2011-12-11 12:59 ` Ming Lei
2011-12-11 15:35 ` Peter Zijlstra [this message]
2011-12-11 20:42 ` Peter Zijlstra
2011-12-12 3:48 ` Ming Lei
2011-12-12 8:54 ` Peter Zijlstra
2011-12-12 9:57 ` Ming Lei
2011-12-12 10:12 ` Peter Zijlstra
2011-12-12 10:32 ` Ming Lei
2011-12-12 11:05 ` Peter Zijlstra
2011-12-12 11:19 ` Ming Lei
2011-12-12 11:13 ` Eric Dumazet
2011-12-12 11:15 ` Oliver Neukum
2011-12-12 10:20 ` Oliver Neukum
2011-12-12 19:30 ` Greg KH
2011-12-12 22:56 ` Oliver Neukum
2011-12-12 23:14 ` Greg KH
2011-12-13 11:51 ` Oliver Neukum
2011-12-13 9:12 ` Peter Zijlstra
2011-12-13 9:49 ` Oliver Neukum
2011-12-12 8:55 ` Peter Zijlstra
2011-12-12 15:24 ` Greg KH
2011-12-12 8:56 ` Peter Zijlstra
2011-12-12 10:10 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323617738.16764.21.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oneukum@suse.de \
--cc=ostrikov@nvidia.com \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox