From: Joe Perches <joe@perches.com>
To: Peter Feuerer <peter@piie.net>
Cc: Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] acerhdf: Message logging neatening
Date: Mon, 12 Dec 2011 10:56:37 -0800 [thread overview]
Message-ID: <1323716197.19538.3.camel@joe2Laptop> (raw)
In-Reply-To: <cone.1323714410.432860.1894.1000@zopiie>
On Mon, 2011-12-12 at 19:26 +0100, Peter Feuerer wrote:
> > @@ -605,8 +603,8 @@ static int acerhdf_check_hardware(void)
> > }
> >
> > if (!bios_cfg) {
> > - pr_err("unknown (unsupported) BIOS version %s/%s/%s, "
> > - "please report, aborting!\n", vendor, product, version);
> > + pr_err("unknown (unsupported) BIOS version %s/%s/%s, please report, aborting!\n",
> > + vendor, product, version);
>
> disagree, as it exceeds 80 chars.
Format strings should be coalesced.
checkpatch ignores these long lines.
next prev parent reply other threads:[~2011-12-12 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 19:04 [PATCH 1/2] acer-wmi: Message logging neatening Joe Perches
2011-11-29 19:04 ` [PATCH 2/2] acerhdf: " Joe Perches
2011-12-12 18:26 ` Peter Feuerer
2011-12-12 18:56 ` Joe Perches [this message]
2011-12-05 3:57 ` [PATCH 1/2] acer-wmi: " joeyli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323716197.19538.3.camel@joe2Laptop \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=peter@piie.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox