From: Peter Zijlstra <peterz@infradead.org>
To: Greg KH <greg@kroah.com>, "Theodore Ts'o" <tytso@mit.edu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>
Subject: printk() vs tty_io
Date: Tue, 13 Dec 2011 20:33:23 +0100 [thread overview]
Message-ID: <1323804803.9082.40.camel@twins> (raw)
Hi tty folks,
I've been poking at reducing the constraints on printk(), like make it
work under rq->lock etc..
Aside from a fwd port of the patch that abuses the console_sem.lock:
https://lkml.org/lkml/2011/6/9/298 and a few other not so very pretty
patches, I ran into the following lockdep splat (using a not so very
pretty lockdep early_printk() patch):
watchdog/0/10 is trying to acquire lock:
((console_sem).lock){-.-...}, at:
but task is already holding lock:
(&rt_rq->rt_runtime_lock){-.-...}, at:
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #5 (&rt_rq->rt_runtime_lock){-.-...}:
-> #4 (&rq->lock){-.-.-.}:
-> #3 (&p->pi_lock){-.-.-.}:
-> #2 (&tty->write_wait){-.-...}:
-> #1 (&port_lock_key){-.-...}:
-> #0 ((console_sem).lock){-.-...}:
It turns out that writing to a console does wakeups due to tty_io.c.
My question is basically, is there a feasible way around doing these
wakeups from the console::write() path? Everything I thought of was
really quite horrible... and very likely would break stuff since I'm not
that well versed in the whole tty thing.
next reply other threads:[~2011-12-13 19:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 19:33 Peter Zijlstra [this message]
2011-12-13 23:52 ` printk() vs tty_io Linus Torvalds
2011-12-14 9:38 ` Peter Zijlstra
2011-12-14 10:43 ` Alan Cox
2011-12-14 10:56 ` Peter Zijlstra
2011-12-14 14:05 ` Ted Ts'o
2011-12-14 14:23 ` Peter Zijlstra
2011-12-14 15:54 ` Linus Torvalds
2011-12-15 9:56 ` Peter Zijlstra
2011-12-15 10:32 ` Alan Cox
2011-12-15 10:55 ` Peter Zijlstra
2011-12-15 17:08 ` Linus Torvalds
2011-12-15 18:07 ` Ingo Molnar
2011-12-15 21:22 ` Alan Cox
2011-12-16 13:25 ` Peter Zijlstra
2011-12-15 19:02 ` Greg KH
2011-12-14 6:59 ` Ingo Molnar
2011-12-14 9:40 ` [PATCH] arch, early_printk: Consolidate early_printk() implementations Peter Zijlstra
2011-12-14 9:41 ` [PATCH] lockdep: Enable earlyprintk output Peter Zijlstra
2011-12-14 9:43 ` printk() vs tty_io Peter Zijlstra
2011-12-14 9:46 ` Ingo Molnar
2011-12-21 12:03 ` Stijn Devriendt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323804803.9082.40.camel@twins \
--to=peterz@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox