From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Robert Richter <robert.richter@amd.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 02/10] perf evsel: Fix uninitialized memory access to struct perf_sample
Date: Tue, 20 Dec 2011 17:18:03 -0200 [thread overview]
Message-ID: <1324408691-28296-3-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1324408691-28296-1-git-send-email-acme@infradead.org>
From: Robert Richter <robert.richter@amd.com>
Memory in struct perf_sample is not fully initialized during parsing.
Depending on sampling data some parts may left unchanged. Zero out
struct perf_sample first to avoid access to uninitialized memory.
Cc: Ingo Molnar <mingo@elte.hu>
Link: http://lkml.kernel.org/r/1323966762-8574-2-git-send-email-robert.richter@amd.com
Signed-off-by: Robert Richter <robert.richter@amd.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/evsel.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 60ad028..667f3b7 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -460,7 +460,7 @@ int perf_event__parse_sample(const union perf_event *event, u64 type,
u32 val32[2];
} u;
-
+ memset(data, 0, sizeof(*data));
data->cpu = data->pid = data->tid = -1;
data->stream_id = data->id = data->time = -1ULL;
--
1.7.8.rc0.35.gee6df
next prev parent reply other threads:[~2011-12-20 19:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-20 19:18 [GIT PULL 00/10] perf/core improvements and fixes Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 01/10] perf record: Add ability to record event period Arnaldo Carvalho de Melo
2011-12-20 19:18 ` Arnaldo Carvalho de Melo [this message]
2011-12-20 19:18 ` [PATCH 03/10] perf report: Document '--call-graph' for optional print_limit argument Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 04/10] perf evlist: Fix errno value reporting on failed mmap Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 05/10] perf symbols: Get rid of duplicated snprintf() Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 06/10] perf symbols: Fix error path on symbol__init() Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 07/10] perf tools: Fix a memory leak on perf_read_values_destroy Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 08/10] perf tools: Remove stale git headlines from top comment Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 09/10] perf events: Tidy up perf_event__preprocess_sample Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 10/10] perf test: Add more automated tests for event parsing Arnaldo Carvalho de Melo
2011-12-20 19:33 ` [GIT PULL 00/10] perf/core improvements and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324408691-28296-3-git-send-email-acme@infradead.org \
--to=acme@infradead.org \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=robert.richter@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).