linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Nelson Elhage <nelhage@nelhage.com>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 04/10] perf evlist: Fix errno value reporting on failed mmap
Date: Tue, 20 Dec 2011 17:18:05 -0200	[thread overview]
Message-ID: <1324408691-28296-5-git-send-email-acme@infradead.org> (raw)
In-Reply-To: <1324408691-28296-1-git-send-email-acme@infradead.org>

From: Nelson Elhage <nelhage@nelhage.com>

On failure, perf_evlist__mmap_per_{cpu,thread} will try to munmap()
every map that doesn't have a NULL base. This will fail with EINVAL if
one of them has base == MAP_FAILED, clobbering errno, so that
perf_evlist__map will return EINVAL on any failure regardless of the
root cause.

Fix this by resetting failed maps to a NULL base.

Acked-by: Namhyung Kim <namhyung@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1324301972-22740-2-git-send-email-nelhage@nelhage.com
Signed-off-by: Nelson Elhage <nelhage@nelhage.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/evlist.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c
index 8b19e7a..963d63d 100644
--- a/tools/perf/util/evlist.c
+++ b/tools/perf/util/evlist.c
@@ -447,8 +447,10 @@ static int __perf_evlist__mmap(struct perf_evlist *evlist,
 	evlist->mmap[idx].mask = mask;
 	evlist->mmap[idx].base = mmap(NULL, evlist->mmap_len, prot,
 				      MAP_SHARED, fd, 0);
-	if (evlist->mmap[idx].base == MAP_FAILED)
+	if (evlist->mmap[idx].base == MAP_FAILED) {
+		evlist->mmap[idx].base = NULL;
 		return -1;
+	}
 
 	perf_evlist__add_pollfd(evlist, fd);
 	return 0;
-- 
1.7.8.rc0.35.gee6df


  parent reply	other threads:[~2011-12-20 19:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-20 19:18 [GIT PULL 00/10] perf/core improvements and fixes Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 01/10] perf record: Add ability to record event period Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 02/10] perf evsel: Fix uninitialized memory access to struct perf_sample Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 03/10] perf report: Document '--call-graph' for optional print_limit argument Arnaldo Carvalho de Melo
2011-12-20 19:18 ` Arnaldo Carvalho de Melo [this message]
2011-12-20 19:18 ` [PATCH 05/10] perf symbols: Get rid of duplicated snprintf() Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 06/10] perf symbols: Fix error path on symbol__init() Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 07/10] perf tools: Fix a memory leak on perf_read_values_destroy Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 08/10] perf tools: Remove stale git headlines from top comment Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 09/10] perf events: Tidy up perf_event__preprocess_sample Arnaldo Carvalho de Melo
2011-12-20 19:18 ` [PATCH 10/10] perf test: Add more automated tests for event parsing Arnaldo Carvalho de Melo
2011-12-20 19:33 ` [GIT PULL 00/10] perf/core improvements and fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324408691-28296-5-git-send-email-acme@infradead.org \
    --to=acme@infradead.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nelhage@nelhage.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).