From: Ian Campbell <Ian.Campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad@darnok.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"FlorianSchandinat@gmx.de" <FlorianSchandinat@gmx.de>,
Jeremy Fitzhardinge <jeremy@goop.org>,
"Jens Axboe" <axboe@kernel.dk>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH, v2] Xen: consolidate and simplify struct xenbus_driver instantiation
Date: Thu, 22 Dec 2011 11:57:40 +0000 [thread overview]
Message-ID: <1324555060.7877.84.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <4EF327E2020000780006993E@nat28.tlf.novell.com>
On Thu, 2011-12-22 at 11:51 +0000, Jan Beulich wrote:
> >>> On 22.12.11 at 10:57, Ian Campbell <Ian.Campbell@citrix.com> wrote:
> > On Thu, 2011-12-22 at 09:08 +0000, Jan Beulich wrote:
> >> The 'name', 'owner', and 'mod_name' members are redundant with the
> >> identically named fields in the 'driver' sub-structure. Rather than
> >> switching each instance to specify these fields explicitly, introduce
> >> a macro to simplify this.
> >>
> >> Eliminate further redundancy by allowing the drvname argument to
> >> DEFINE_XENBUS_DRIVER() to be blank (in which case the first entry from
> >> the ID table will be used for .driver.name).
> >
> > Any reason not to always use DRV_NAME here (which is generally a bit
> > more specific e.g. "xen-foofront" rather than "foo") and rely on the id
> > table for the shorter names used in xenstore?
>
> That would imply that DRV_NAME is always defined, but I don't
> see this being the case.
My mistake, I thought it was a Kbuild thing.
Ian.
next prev parent reply other threads:[~2011-12-22 11:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-22 9:08 [PATCH, v2] Xen: consolidate and simplify struct xenbus_driver instantiation Jan Beulich
2011-12-22 9:57 ` Ian Campbell
2011-12-22 11:51 ` Jan Beulich
2011-12-22 11:57 ` Ian Campbell [this message]
2011-12-22 14:44 ` Ben Hutchings
2011-12-22 20:38 ` Ian Campbell
2012-01-03 20:36 ` Konrad Rzeszutek Wilk
2012-01-04 9:17 ` Jan Beulich
2012-01-04 9:20 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1324555060.7877.84.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=FlorianSchandinat@gmx.de \
--cc=JBeulich@suse.com \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=dmitry.torokhov@gmail.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=konrad@darnok.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox