* [PATCH] [RFC] ubi: Make vid_hdr non-static
@ 2011-12-22 15:12 Richard Weinberger
2011-12-22 16:06 ` Artem Bityutskiy
0 siblings, 1 reply; 4+ messages in thread
From: Richard Weinberger @ 2011-12-22 15:12 UTC (permalink / raw)
To: linux-mtd; +Cc: dedekind1, dwmw2, linux-kernel, tglx, Richard Weinberger
There is no reason to have vid_hdr static.
Signed-off-by: Richard Weinberger <rw@linutronix.de>
---
drivers/mtd/ubi/vtbl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/ubi/vtbl.c b/drivers/mtd/ubi/vtbl.c
index 9ad18da..890754c 100644
--- a/drivers/mtd/ubi/vtbl.c
+++ b/drivers/mtd/ubi/vtbl.c
@@ -306,7 +306,7 @@ static int create_vtbl(struct ubi_device *ubi, struct ubi_scan_info *si,
int copy, void *vtbl)
{
int err, tries = 0;
- static struct ubi_vid_hdr *vid_hdr;
+ struct ubi_vid_hdr *vid_hdr;
struct ubi_scan_leb *new_seb;
ubi_msg("create volume table (copy #%d)", copy + 1);
--
1.7.7
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] [RFC] ubi: Make vid_hdr non-static
2011-12-22 15:12 [PATCH] [RFC] ubi: Make vid_hdr non-static Richard Weinberger
@ 2011-12-22 16:06 ` Artem Bityutskiy
2011-12-22 16:05 ` Richard Weinberger
2012-01-09 15:12 ` Artem Bityutskiy
0 siblings, 2 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2011-12-22 16:06 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-mtd, dwmw2, linux-kernel, tglx
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
On Thu, 2011-12-22 at 16:12 +0100, Richard Weinberger wrote:
> There is no reason to have vid_hdr static.
>
> Signed-off-by: Richard Weinberger <rw@linutronix.de>
> ---
> drivers/mtd/ubi/vtbl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mtd/ubi/vtbl.c b/drivers/mtd/ubi/vtbl.c
> index 9ad18da..890754c 100644
> --- a/drivers/mtd/ubi/vtbl.c
> +++ b/drivers/mtd/ubi/vtbl.c
> @@ -306,7 +306,7 @@ static int create_vtbl(struct ubi_device *ubi, struct ubi_scan_info *si,
> int copy, void *vtbl)
> {
> int err, tries = 0;
> - static struct ubi_vid_hdr *vid_hdr;
> + struct ubi_vid_hdr *vid_hdr;
> struct ubi_scan_leb *new_seb;
Hmm, this shouldn't be [RFC] - this a bugfix, I'll merge it, thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] [RFC] ubi: Make vid_hdr non-static
2011-12-22 16:06 ` Artem Bityutskiy
@ 2011-12-22 16:05 ` Richard Weinberger
2012-01-09 15:12 ` Artem Bityutskiy
1 sibling, 0 replies; 4+ messages in thread
From: Richard Weinberger @ 2011-12-22 16:05 UTC (permalink / raw)
To: dedekind1; +Cc: linux-mtd, dwmw2, linux-kernel, tglx
On 22.12.2011 17:06, Artem Bityutskiy wrote:
> Hmm, this shouldn't be [RFC] - this a bugfix, I'll merge it, thanks!
>
I'm new to UBI, so I was not sure. :-)
Thanks,
//richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [RFC] ubi: Make vid_hdr non-static
2011-12-22 16:06 ` Artem Bityutskiy
2011-12-22 16:05 ` Richard Weinberger
@ 2012-01-09 15:12 ` Artem Bityutskiy
1 sibling, 0 replies; 4+ messages in thread
From: Artem Bityutskiy @ 2012-01-09 15:12 UTC (permalink / raw)
To: Richard Weinberger; +Cc: linux-mtd, dwmw2, linux-kernel, tglx
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On Thu, 2011-12-22 at 18:06 +0200, Artem Bityutskiy wrote:
> On Thu, 2011-12-22 at 16:12 +0100, Richard Weinberger wrote:
> > There is no reason to have vid_hdr static.
> >
> > Signed-off-by: Richard Weinberger <rw@linutronix.de>
> > ---
> > drivers/mtd/ubi/vtbl.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/mtd/ubi/vtbl.c b/drivers/mtd/ubi/vtbl.c
> > index 9ad18da..890754c 100644
> > --- a/drivers/mtd/ubi/vtbl.c
> > +++ b/drivers/mtd/ubi/vtbl.c
> > @@ -306,7 +306,7 @@ static int create_vtbl(struct ubi_device *ubi, struct ubi_scan_info *si,
> > int copy, void *vtbl)
> > {
> > int err, tries = 0;
> > - static struct ubi_vid_hdr *vid_hdr;
> > + struct ubi_vid_hdr *vid_hdr;
> > struct ubi_scan_leb *new_seb;
>
> Hmm, this shouldn't be [RFC] - this a bugfix, I'll merge it, thanks!
Pushed to ubifs-2.6 git tree with "Cc: stable@kernel.org", thanks!
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-09 15:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-22 15:12 [PATCH] [RFC] ubi: Make vid_hdr non-static Richard Weinberger
2011-12-22 16:06 ` Artem Bityutskiy
2011-12-22 16:05 ` Richard Weinberger
2012-01-09 15:12 ` Artem Bityutskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).