From: Yanmin Zhang <yanmin_zhang@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
shaohua.li@intel.com, len.brown@intel.com,
mingmingx.zhang@intel.com
Subject: Re: [Fwd: [patch] intel_idle: Delete meaningless local_irq_disable() call in intel_idle.c.]
Date: Wed, 28 Dec 2011 08:27:12 +0800 [thread overview]
Message-ID: <1325032032.3860.17.camel@ymzhang> (raw)
In-Reply-To: <20111227161034.1969c006.akpm@linux-foundation.org>
On Tue, 2011-12-27 at 16:10 -0800, Andrew Morton wrote:
> On Mon, 26 Dec 2011 09:28:20 +0800
> Yanmin Zhang <yanmin_zhang@linux.intel.com> wrote:
>
> > Andrew,
> >
> > Would you like to accept the patch into your testing tree?
>
> hm, that's three indel_idle patches which I have now. Someone wake up
> lenb!
>
> > intel_idle.c is a bit misleading in a sense that local_irq_disable,it
>
> I'd suggest adding this as well:
Agree. It'll be clearer.
>
> --- a/drivers/idle/intel_idle.c~drivers-idle-intel_idlec-remove-redundant-local_irq_disable-call-fix
> +++ a/drivers/idle/intel_idle.c
> @@ -232,6 +232,7 @@ static int get_driver_data(int cstate)
> * @drv: cpuidle driver
> * @index: index of cpuidle state
> *
> + * Must be called under local_irq_disable().
> */
> static int intel_idle(struct cpuidle_device *dev,
> struct cpuidle_driver *drv, int index)
prev parent reply other threads:[~2011-12-28 0:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-26 1:28 [Fwd: [patch] intel_idle: Delete meaningless local_irq_disable() call in intel_idle.c.] Yanmin Zhang
2011-12-28 0:10 ` Andrew Morton
2011-12-28 0:27 ` Yanmin Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325032032.3860.17.camel@ymzhang \
--to=yanmin_zhang@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingmingx.zhang@intel.com \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox