From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754644Ab2ACSnB (ORCPT ); Tue, 3 Jan 2012 13:43:01 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:55174 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754490Ab2ACSnA (ORCPT ); Tue, 3 Jan 2012 13:43:00 -0500 Message-ID: <1325616176.21062.4.camel@joe2Laptop> Subject: Re: [PATCH] bnx2fc: Reduce object size by consolidating formats From: Joe Perches To: Bhanu Prakash Gollapudi Cc: "James E.J. Bottomley" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Tue, 03 Jan 2012 10:42:56 -0800 In-Reply-To: <4ECC5097.2050908@broadcom.com> References: <4ECC5097.2050908@broadcom.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.1- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2011-11-22 at 17:47 -0800, Bhanu Prakash Gollapudi wrote: > On 11/19/2011 1:35 PM, Joe Perches wrote: > > Deduplication of formats and consolidating tests > > makes the object much smaller. > > > > Add bnx2fc_debug.c, add functions for a few logging > > functions (BNX2FC_IO_DBG, BNX2FC_TGT_DBG, BNX2FC_HBA_DBG). > > Use printf extension %pV. > > Add and use pr_fmt and pr_. > > Move the debug #include below structure definitions. > > > > $ size drivers/scsi/bnx2fc/built-in.o* > > text data bss dec hex filename > > 101563 1165 24976 127704 1f2d8 drivers/scsi/bnx2fc/built-in.o.new > > 138473 1109 33400 172982 2a3b6 drivers/scsi/bnx2fc/built-in.o.old > > > > Signed-off-by: Joe Perches > Thanks Joe. > > Acked-by: Bhanu Prakash Gollapudi Still unmerged after 6 weeks. What's happening with this?