From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757396Ab2ADXlQ (ORCPT ); Wed, 4 Jan 2012 18:41:16 -0500 Received: from perches-mx.perches.com ([206.117.179.246]:43742 "EHLO labridge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752281Ab2ADXlN (ORCPT ); Wed, 4 Jan 2012 18:41:13 -0500 Message-ID: <1325720472.4116.7.camel@joe2Laptop> Subject: Re: [PATCH 5/6] ath6kl: convert ath6kl_dbg() and ath6kl_dbg_dump() into functions From: Joe Perches To: Kalle Valo Cc: linville@tuxdriver.com, sfr@canb.auug.org.au, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, ath6kl-devel@qualcomm.com, davem@davemloft.net Date: Wed, 04 Jan 2012 15:41:12 -0800 In-Reply-To: <20120104230950.32306.21264.stgit@x201> References: <20120104230429.32306.75965.stgit@x201> <20120104230950.32306.21264.stgit@x201> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.1- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2012-01-05 at 01:09 +0200, Kalle Valo wrote: > That way it's possible to not export debug_mask outside the upcoming > ath6kl_core.ko and that makes it easier to ath6kl_core.ko in the > following patch. [] > Signed-off-by: Kalle Valo [] > diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c [] > +void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...) > +{ > + va_list args; > + > + if (!(debug_mask & mask)) > + return; > + > + va_start(args, fmt); > + ath6kl_printk(KERN_DEBUG, fmt, &args); Passing a va_list as an argument? I believe this doesn't work. I think you'll need to add and use: struct va_format vaf; vaf.fmt = fmt; vaf.va = &args; ath6kl_printk(KERN_DEBUG, "%pV", &vaf);