From: Namhyung Kim <namhyung@gmail.com>
To: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 7/9] perf annotate: Get rid of field_sep check
Date: Mon, 09 Jan 2012 01:11:29 +0900 [thread overview]
Message-ID: <1326039089.1947.12.camel@leonhard> (raw)
In-Reply-To: <1326037339-31125-8-git-send-email-acme@infradead.org>
2012-01-08 (Sun), 13:42 -0200, Arnaldo Carvalho de Melo wrote:
> From: Namhyung Kim <namhyung@gmail.com>
>
> The 'field_sep' variable is not set anywhere. Just remove the
> conditional.
>
BTW, it seems there's no user of the variable now. Maybe a candidate
for removal?
Thanks.
--
Regards,
Namhyung Kim
next prev parent reply other threads:[~2012-01-08 16:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-08 15:42 [GIT PULL 0/9] perf/core fixes and improvements Arnaldo Carvalho de Melo
2012-01-08 15:42 ` [PATCH 1/9] perf script: Add missing closedir() calls Arnaldo Carvalho de Melo
2012-01-08 15:42 ` [PATCH 2/9] perf test: Change type of '-v' option to INCR Arnaldo Carvalho de Melo
2012-01-08 15:42 ` [PATCH 3/9] perf top: Add error message for EMFILE Arnaldo Carvalho de Melo
2012-01-08 15:42 ` [PATCH 4/9] perf kmem: Add missing closedir() calls Arnaldo Carvalho de Melo
2012-01-08 15:42 ` [PATCH 5/9] perf kmem: Fix a memory leak Arnaldo Carvalho de Melo
2012-01-08 15:42 ` [PATCH 6/9] perf annotate: Fix usage string Arnaldo Carvalho de Melo
2012-01-08 15:42 ` [PATCH 7/9] perf annotate: Get rid of field_sep check Arnaldo Carvalho de Melo
2012-01-08 16:11 ` Namhyung Kim [this message]
2012-01-08 15:42 ` [PATCH 8/9] perf report: Fix --stdio output alignment when --showcpuutilization used Arnaldo Carvalho de Melo
2012-01-08 15:42 ` [PATCH 9/9] perf tools: Fix compile error on x86_64 Ubuntu Arnaldo Carvalho de Melo
2012-01-08 16:02 ` [GIT PULL 0/9] perf/core fixes and improvements Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326039089.1947.12.camel@leonhard \
--to=namhyung@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).