From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755302Ab2AICwz (ORCPT ); Sun, 8 Jan 2012 21:52:55 -0500 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:53128 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467Ab2AICwx (ORCPT ); Sun, 8 Jan 2012 21:52:53 -0500 Message-ID: <1326077566.4097.7.camel@deadeye> Subject: Re: [PATCH 1/2] topology: Check for missing CPU devices From: Ben Hutchings To: Linus Torvalds Cc: richard -rw- weinberger , Greg Kroah-Hartman , Geert Uytterhoeven , Andrew Morton , linux-kernel@vger.kernel.org, Linux-Arch , Thorsten Glaser , Debian kernel team , linux-m68k@vger.kernel.org, debian-68k@lists.debian.org Date: Mon, 09 Jan 2012 02:52:46 +0000 In-Reply-To: References: <1326055714.13595.309.camel@deadeye> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-RKEqcBw08P14vBh4EUOt" X-Mailer: Evolution 3.2.2-1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:470:1f08:1539:21c:bfff:fe03:f805 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-RKEqcBw08P14vBh4EUOt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2012-01-08 at 17:29 -0800, Linus Torvalds wrote: > On Sun, Jan 8, 2012 at 5:06 PM, richard -rw- weinberger > wrote: > > On Mon, Jan 9, 2012 at 1:18 AM, Linus Torvalds > > wrote: > >> Ok, both of the patches look sane to me, but it would really be nice > >> to hear from somebody with the actual affected architectures, and get > >> a tested-by. > > > > UML is affected: > > https://lkml.org/lkml/2012/1/8/186 > > > > I wasted an hour finding out why it is crashing. > > Instead of testing kernels I really should read more LKML. ;-) >=20 > Hmm. >=20 > Ben - how about that >=20 > static DEFINE_PER_CPU(struct cpu, cpu_devices); >=20 > approach that Richard uses in his patch, instead of the kcalloc? That seems perfectly good. > And > clearly UM should also do that CONFIG_GENERIC_CPU_DEVICES thing with > your patch. > > Richard - does Ben's patch work for you too if you just add "select > GENERIC_CPU_DEVICES" in the UM Kconfig too (Kconfig.common, probably)? Sorry, I meant to cover UM as well but I couldn't see how its Kconfig files were organised. Ben. --=20 Ben Hutchings Life is what happens to you while you're busy making other plans. - John Lenno= n --=-RKEqcBw08P14vBh4EUOt Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIVAwUATwpWfue/yOyVhhEJAQrmtw/+NgIHg4M4/jyGZhq8suuOotDLW1rp4ZOT KFPFwhmJ0O5t6aEbhkmBBWdf/NnkMMGGTolRuWNkieppSKcESJOBHoF+34eD79L6 oz4oOlaVU/z90S+Gw98/dZEktD9PnOfBr8bF4bNsh2AWPadwqeIRRhatwzk0PUHE dyiKbW6KdtlTSiUmnmknJ9OyVkB+tTqp9eKTU0BknMCMSNRclJZcbrWsviipBMMh N9/HlWaC0Vljn3E5HKM7VZ5segN1ktbMu8NWTDTpFXT0Cr1f3pOD1sXz3IH0l5Ii S0+YLK2ubJRiRFAHseyS9y6qlsB9W5CGJdo+VDkFDJfQ/K8YRu4kcwqmSNbcceaI wWoyJAt5xgTHClomLde36IkN01JX/WQ6e1Jd6V72HrRtZjO/jeT3c0wXS3W06+BP N2itvaSBSJxlZ9JZ5hWSuCz5MwcqMqoV76mg1t2I8f0WmQZtuZbGsHQ8/gFEL9Lk fpTBEPlQuS8QoRfX/SatZwMypfUcy67P/Nhui+2TyBCrGyotBGqBHn3LJGW/40D+ QA/XECv/umgpXLhEgB8w5GX4NmEiR9QUQtWwoQKN3DszlmIWLS00X9l+nFP5Zcj/ kdXhhiFQVEZdBFYkasJ/il4AcqxeWmBOuS0/Q3KwDa02i180w7Sr1J7EaHMLKitH 7gY3lWpxHo8= =t+UK -----END PGP SIGNATURE----- --=-RKEqcBw08P14vBh4EUOt--