From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Youquan Song <youquan.song@intel.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
hpa@zytor.com, akpm@linux-foundation.org, stable@vger.kernel.org,
suresh.b.siddha@intel.com, arjan@linux.intel.com,
len.brown@intel.com, anhua.xu@intel.com, chaohong.guo@intel.com,
Youquan Song <youquan.song@linux.intel.com>
Subject: Re: [PATCH] x86,sched: Fix sched_smt_power_savings totally broken
Date: Mon, 09 Jan 2012 12:12:43 +0100 [thread overview]
Message-ID: <1326107563.2442.65.camel@twins> (raw)
In-Reply-To: <20120110001445.GA20542@linux-youquan.bj.intel.com>
On Mon, 2012-01-09 at 19:14 -0500, Youquan Song wrote:
> > Yes it is.. also that knob should die! Like i've been saying for way too
> > long. I'm >< close to committing a patch removing all the power_saving
> > magic from the scheduler.
> Sorry. I do not notice it.
I hadn't posted it before, but just about every time people post
something related to smt/mc power balancing I say this needs to get
cleaned up. Since telling people doesn't seem to have any effect what so
ever, stronger measures are needed.
> But currently in many real tests, the knob prove to save power in semi-idle system.
> They are useful in many user scenarios currently.
I'm not saying the stuff is without merit, I'm just saying that a) the
interface is utter crap and b) nobody seems to spend enough time on it
to 1) understand the load-balancer so that 2) he can integrate the power
saving stuff properly.
Instead I get one sporadic band-aid after another.
Also, fundamentally, the split between {smt/mc/numa/book}_power_savings
is completely and fundamentally broken, nobody cares about the actual
topology.
next prev parent reply other threads:[~2012-01-09 11:12 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 8:56 [PATCH] x86,sched: Fix sched_smt_power_savings totally broken Youquan Song
2012-01-09 10:06 ` Peter Zijlstra
2012-01-09 10:28 ` Peter Zijlstra
2012-01-09 10:30 ` Peter Zijlstra
2012-01-09 11:00 ` Vaidyanathan Srinivasan
2012-01-09 14:35 ` Peter Zijlstra
2012-01-09 16:03 ` Vaidyanathan Srinivasan
2012-01-09 16:13 ` Peter Zijlstra
2012-01-09 17:05 ` Vaidyanathan Srinivasan
2012-01-09 14:13 ` Arjan van de Ven
2012-05-18 10:19 ` [tip:sched/core] sched: Remove stale power aware scheduling remnants and dysfunctional knobs tip-bot for Peter Zijlstra
2012-01-10 0:14 ` [PATCH] x86,sched: Fix sched_smt_power_savings totally broken Youquan Song
2012-01-09 11:05 ` Peter Zijlstra
2012-01-10 5:58 ` Youquan Song
2012-01-09 23:52 ` Suresh Siddha
2012-01-10 9:18 ` Ingo Molnar
2012-01-10 14:32 ` Arjan van de Ven
2012-01-10 14:41 ` Peter Zijlstra
2012-01-10 14:54 ` Arjan van de Ven
2012-01-10 15:32 ` Vincent Guittot
2012-01-10 16:49 ` Vaidyanathan Srinivasan
2012-01-10 19:41 ` Ingo Molnar
2012-01-10 19:44 ` Ingo Molnar
2012-01-10 16:54 ` Youquan Song
2012-01-10 16:51 ` Vaidyanathan Srinivasan
2012-01-10 19:01 ` Suresh Siddha
2012-01-11 3:52 ` Vaidyanathan Srinivasan
2012-01-11 17:37 ` Youquan Song
2012-01-10 16:44 ` Vaidyanathan Srinivasan
2012-01-09 11:12 ` Peter Zijlstra [this message]
2012-01-09 14:29 ` Vincent Guittot
2012-01-09 14:46 ` Peter Zijlstra
2012-01-10 2:12 ` Indan Zupancic
2012-01-10 9:26 ` Peter Zijlstra
2012-01-10 1:54 ` Suresh Siddha
2012-01-10 8:08 ` Vincent Guittot
2012-01-09 15:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326107563.2442.65.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=anhua.xu@intel.com \
--cc=arjan@linux.intel.com \
--cc=chaohong.guo@intel.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=stable@vger.kernel.org \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=youquan.song@intel.com \
--cc=youquan.song@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox