From: Tejun Heo <tj@kernel.org>
To: axboe@kernel.dk, mingo@redhat.com, rostedt@goodmis.org,
fweisbec@gmail.com, teravest@google.com, slavapestov@google.com,
ctalbott@google.com, dhsharp@google.com
Cc: linux-kernel@vger.kernel.org, winget@google.com,
namhyung@gmail.com, Tejun Heo <tj@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: [PATCH 8/9] stacktrace: implement save_stack_trace_quick()
Date: Tue, 10 Jan 2012 10:28:25 -0800 [thread overview]
Message-ID: <1326220106-5765-9-git-send-email-tj@kernel.org> (raw)
In-Reply-To: <1326220106-5765-1-git-send-email-tj@kernel.org>
Implement save_stack_trace_quick() which only considers the usual
contexts (ie. thread and irq) and doesn't handle links between
different contexts - if %current is in irq context, only backtrace in
the irq stack is considered.
This is subset of dump_trace() done in much simpler way. It's
intended to be used in hot paths where the overhead of dump_trace()
can be too heavy.
Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
---
arch/x86/include/asm/stacktrace.h | 2 +
arch/x86/kernel/stacktrace.c | 40 +++++++++++++++++++++++++++++++++++++
include/linux/stacktrace.h | 6 +++++
kernel/stacktrace.c | 6 +++++
4 files changed, 54 insertions(+), 0 deletions(-)
diff --git a/arch/x86/include/asm/stacktrace.h b/arch/x86/include/asm/stacktrace.h
index 70bbe39..06bbdfc 100644
--- a/arch/x86/include/asm/stacktrace.h
+++ b/arch/x86/include/asm/stacktrace.h
@@ -50,9 +50,11 @@ void dump_trace(struct task_struct *tsk, struct pt_regs *regs,
#ifdef CONFIG_X86_32
#define STACKSLOTS_PER_LINE 8
#define get_bp(bp) asm("movl %%ebp, %0" : "=r" (bp) :)
+#define get_irq_stack_end() 0
#else
#define STACKSLOTS_PER_LINE 4
#define get_bp(bp) asm("movq %%rbp, %0" : "=r" (bp) :)
+#define get_irq_stack_end() (unsigned long)this_cpu_read(irq_stack_ptr)
#endif
#ifdef CONFIG_FRAME_POINTER
diff --git a/arch/x86/kernel/stacktrace.c b/arch/x86/kernel/stacktrace.c
index fdd0c64..f53ec547 100644
--- a/arch/x86/kernel/stacktrace.c
+++ b/arch/x86/kernel/stacktrace.c
@@ -81,6 +81,46 @@ void save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace)
}
EXPORT_SYMBOL_GPL(save_stack_trace_tsk);
+#ifdef CONFIG_FRAME_POINTER
+void save_stack_trace_quick(struct stack_trace *trace)
+{
+ const unsigned long stk_sz = THREAD_SIZE - sizeof(struct stack_frame);
+ unsigned long tstk = (unsigned long)current_thread_info();
+ unsigned long istk = get_irq_stack_end();
+ unsigned long last_bp = 0;
+ unsigned long bp, stk;
+
+ get_bp(bp);
+
+ if (bp > tstk && bp <= tstk + stk_sz)
+ stk = tstk;
+ else if (istk && (bp > istk && bp <= stk_sz))
+ stk = istk;
+ else
+ goto out;
+
+ while (bp > last_bp && bp <= stk + stk_sz) {
+ struct stack_frame *frame = (struct stack_frame *)bp;
+ unsigned long ret_addr = frame->return_address;
+
+ if (!trace->skip) {
+ if (trace->nr_entries >= trace->max_entries)
+ return;
+ trace->entries[trace->nr_entries++] = ret_addr;
+ } else {
+ trace->skip--;
+ }
+
+ last_bp = bp;
+ bp = (unsigned long)frame->next_frame;
+ }
+out:
+ if (trace->nr_entries < trace->max_entries)
+ trace->entries[trace->nr_entries++] = ULONG_MAX;
+}
+EXPORT_SYMBOL_GPL(save_stack_trace_quick);
+#endif
+
/* Userspace stacktrace - based on kernel/trace/trace_sysprof.c */
struct stack_frame_user {
diff --git a/include/linux/stacktrace.h b/include/linux/stacktrace.h
index 115b570..d5b16c4 100644
--- a/include/linux/stacktrace.h
+++ b/include/linux/stacktrace.h
@@ -19,6 +19,12 @@ extern void save_stack_trace_regs(struct pt_regs *regs,
extern void save_stack_trace_tsk(struct task_struct *tsk,
struct stack_trace *trace);
+/*
+ * Saves only trace from the current context. Doesn't handle exception
+ * stacks or verify text address.
+ */
+extern void save_stack_trace_quick(struct stack_trace *trace);
+
extern void print_stack_trace(struct stack_trace *trace, int spaces);
#ifdef CONFIG_USER_STACKTRACE_SUPPORT
diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c
index 00fe55c..4760949 100644
--- a/kernel/stacktrace.c
+++ b/kernel/stacktrace.c
@@ -31,6 +31,12 @@ EXPORT_SYMBOL_GPL(print_stack_trace);
* (whenever this facility is utilized - for example by procfs):
*/
__weak void
+save_stack_trace_quick(struct stack_trace *trace)
+{
+ WARN_ONCE(1, KERN_INFO "save_stack_trace_quick() not implemented yet.\n");
+}
+
+__weak void
save_stack_trace_tsk(struct task_struct *tsk, struct stack_trace *trace)
{
WARN_ONCE(1, KERN_INFO "save_stack_trace_tsk() not implemented yet.\n");
--
1.7.3.1
next prev parent reply other threads:[~2012-01-10 18:29 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 18:28 [RFC PATCHSET take#2] ioblame: IO tracer with origin tracking Tejun Heo
2012-01-10 18:28 ` [PATCH 1/9] block: abstract disk iteration into disk_iter Tejun Heo
2012-01-10 18:28 ` [PATCH 2/9] block: block_bio_complete tracepoint was missing Tejun Heo
2012-01-11 17:25 ` Steven Rostedt
2012-01-11 17:30 ` Tejun Heo
2012-01-12 0:24 ` Namhyung Kim
2012-01-10 18:28 ` [PATCH 3/9] block: add @req to bio_{front|back}_merge tracepoints Tejun Heo
2012-01-10 18:28 ` [PATCH 4/9] writeback: move struct wb_writeback_work to writeback.h Tejun Heo
2012-01-10 18:28 ` [PATCH 5/9] writeback: add more tracepoints Tejun Heo
2012-01-10 18:28 ` [PATCH 6/9] block: add block_touch_buffer tracepoint Tejun Heo
2012-01-11 17:42 ` Steven Rostedt
2012-01-11 17:58 ` Tejun Heo
2012-01-10 18:28 ` [PATCH 7/9] vfs: add fcheck tracepoint Tejun Heo
2012-01-10 18:28 ` Tejun Heo [this message]
2012-01-11 16:26 ` [PATCH 8/9] stacktrace: implement save_stack_trace_quick() Frederic Weisbecker
2012-01-11 16:38 ` Tejun Heo
2012-01-11 17:37 ` Tejun Heo
2012-01-17 2:22 ` Frederic Weisbecker
2012-01-10 18:28 ` [PATCH 9/9] block, trace: implement ioblame - IO tracer with origin tracking Tejun Heo
2012-01-11 0:25 ` Chanho Park
2012-01-11 1:04 ` Tejun Heo
2012-01-11 1:32 ` [PATCH RESEND " Tejun Heo
2012-01-11 6:15 ` Namhyung Kim
2012-01-11 17:06 ` Tejun Heo
2012-01-12 1:05 ` Namhyung Kim
2012-01-12 1:14 ` Tejun Heo
2012-01-12 1:35 ` Namhyung Kim
2012-01-12 1:37 ` Tejun Heo
2012-01-12 1:40 ` Namhyung Kim
2012-01-12 1:41 ` Namhyung Kim
2012-01-12 1:44 ` Tejun Heo
2012-01-12 2:19 ` Namhyung Kim
2012-01-12 2:24 ` Tejun Heo
2012-01-11 18:08 ` Tejun Heo
2012-01-11 14:40 ` [RFC PATCHSET take#2] ioblame: " Frederic Weisbecker
2012-01-11 17:02 ` Tejun Heo
2012-01-11 22:45 ` David Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326220106-5765-9-git-send-email-tj@kernel.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=ctalbott@google.com \
--cc=dhsharp@google.com \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@gmail.com \
--cc=rostedt@goodmis.org \
--cc=slavapestov@google.com \
--cc=teravest@google.com \
--cc=winget@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox