[PATCH] power_supply: Add MODULE_DEVICE_TABLE for lp8727 charger

[PATCH] power_supply: Add MODULE_DEVICE_TABLE for lp8727 charger

[Axel Lin]

Add MODULE_DEVICE_TABLE to setup modalias for lp8727.
The i2c_device_id table is supposed to be zero-terminated.
Thus add a missing terminate entry for lp8727_ids.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/power/lp8727_charger.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/power/lp8727_charger.c b/drivers/power/lp8727_charger.c
index b15b575..8e901c9 100644
--- a/drivers/power/lp8727_charger.c
+++ b/drivers/power/lp8727_charger.c
@@ -464,7 +464,9 @@ static int __devexit lp8727_remove(struct i2c_client *cl)
 
 static const struct i2c_device_id lp8727_ids[] = {
 	{"lp8727", 0},
+	{ },
 };
+MODULE_DEVICE_TABLE(i2c, lp8727_ids);
 
 static struct i2c_driver lp8727_driver = {
 	.driver = {
-- 
1.7.5.4

RE: [PATCH] power_supply: Add MODULE_DEVICE_TABLE for lp8727 charger

[Kim, Milo]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 1586 bytes --]

> Add MODULE_DEVICE_TABLE to setup modalias for lp8727.

Autoloading this module is not required.
The LP8727 includes a charger function with the micro/mini USB interface.
Charging a battery and detecting which cable is inserted, this kind of job must be started at the beginning of system boot.
So the lp8727 driver should be loaded before an user-space accesses this driver.

Thanks & BR
Milo -

-----Original Message-----
From: Axel Lin [mailto:axel.lin@gmail.com] 
Sent: Thursday, January 12, 2012 9:45 PM
To: linux-kernel@vger.kernel.org
Cc: Kim, Milo; Jeong, Daniel; Anton Vorontsov
Subject: [PATCH] power_supply: Add MODULE_DEVICE_TABLE for lp8727 charger

Add MODULE_DEVICE_TABLE to setup modalias for lp8727.
The i2c_device_id table is supposed to be zero-terminated.
Thus add a missing terminate entry for lp8727_ids.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/power/lp8727_charger.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/power/lp8727_charger.c b/drivers/power/lp8727_charger.c
index b15b575..8e901c9 100644
--- a/drivers/power/lp8727_charger.c
+++ b/drivers/power/lp8727_charger.c
@@ -464,7 +464,9 @@ static int __devexit lp8727_remove(struct i2c_client *cl)
 
 static const struct i2c_device_id lp8727_ids[] = {
 	{"lp8727", 0},
+	{ },
 };
+MODULE_DEVICE_TABLE(i2c, lp8727_ids);
 
 static struct i2c_driver lp8727_driver = {
 	.driver = {
-- 
1.7.5.4



ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH] power_supply: Add MODULE_DEVICE_TABLE for lp8727 charger

[Axel Lin]

2012/1/16 Kim, Milo <Milo.Kim@ti.com>:
>> Add MODULE_DEVICE_TABLE to setup modalias for lp8727.
>
> Autoloading this module is not required.
Well, Then I'll send a patch to just add terminating entry for
i2c_device_id table.

> The LP8727 includes a charger function with the micro/mini USB interface.
> Charging a battery and detecting which cable is inserted, this kind of job must be started at the beginning of system boot.
> So the lp8727 driver should be loaded before an user-space accesses this driver.
If this driver can be built as a module, people may load/unload the
module anytime ( and I think this is nothing to do with autoloading).

Regards,
Axel

Re: [PATCH] power_supply: Add MODULE_DEVICE_TABLE for lp8727 charger

[Anton Vorontsov]

On Thu, Jan 12, 2012 at 08:45:02PM +0800, Axel Lin wrote:
> Add MODULE_DEVICE_TABLE to setup modalias for lp8727.
> The i2c_device_id table is supposed to be zero-terminated.
> Thus add a missing terminate entry for lp8727_ids.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
>  drivers/power/lp8727_charger.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/power/lp8727_charger.c b/drivers/power/lp8727_charger.c
> index b15b575..8e901c9 100644
> --- a/drivers/power/lp8727_charger.c
> +++ b/drivers/power/lp8727_charger.c
> @@ -464,7 +464,9 @@ static int __devexit lp8727_remove(struct i2c_client *cl)
>  
>  static const struct i2c_device_id lp8727_ids[] = {
>  	{"lp8727", 0},
> +	{ },
>  };
> +MODULE_DEVICE_TABLE(i2c, lp8727_ids);

Applied, thank you!

-- 
Anton Vorontsov
Email: cbouatmailru@gmail.com