public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Davidlohr Bueso <dave@gnu.org>
To: Wang YanQing <udknight@gmail.com>
Cc: mmarek@suse.cz, linux-kernel@vger.kernel.org,
	linux-kbuild@vger.kernel.org, lacombar@gmail.com
Subject: Re: [PATCH] scripts:kconfig:mconf.c: let make not report error when not save configuration
Date: Thu, 12 Jan 2012 21:50:37 +0100	[thread overview]
Message-ID: <1326401437.3416.0.camel@offbook> (raw)
In-Reply-To: <20120112033132.GA13752@udknight>

On Thu, 2012-01-12 at 11:31 +0800, Wang YanQing wrote:
> I find every time when I choice the 'NO' button at the dialog
> which let me choice whether to save the configuration before exit
> menuconfig, it always report the blow:
> 
> " GEN     /mnt/sda7/home/build/test/Makefile
>   HOSTCC  scripts/kconfig/mconf.o
>   HOSTLD  scripts/kconfig/mconf
> scripts/kconfig/mconf Kconfig
> 
> Your configuration changes were NOT saved.
> 
> make[2]: *** [menuconfig] Error 1
> make[1]: *** [menuconfig] Error 2
> make: *** [sub-make] Error 2 "
> 
> This patch repair it.
> 
> Thanks!
> 
> Signed-off-by: Wang YanQing <udknight@gmail.com>

Acked-by: Davidlohr Bueso <dave@gnu.org>

> ---
>  scripts/kconfig/mconf.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/kconfig/mconf.c b/scripts/kconfig/mconf.c
> index 19e200d..86cd1ea 100644
> --- a/scripts/kconfig/mconf.c
> +++ b/scripts/kconfig/mconf.c
> @@ -830,6 +830,7 @@ static int handle_exit(void)
>  		fprintf(stderr, _("\n\n"
>  				  "Your configuration changes were NOT saved."
>  				  "\n\n"));
> +		res = 0;
>  	}
>  
>  	return res;



  reply	other threads:[~2012-01-12 20:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-12  3:31 [PATCH] scripts:kconfig:mconf.c: let make not report error when not save configuration Wang YanQing
2012-01-12 20:50 ` Davidlohr Bueso [this message]
2012-01-14 20:55   ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1326401437.3416.0.camel@offbook \
    --to=dave@gnu.org \
    --cc=lacombar@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=udknight@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox