From: Alberto Panizzo <maramaopercheseimorto@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] backlight: Return proper error in l4f00242t03_probe if regulator_get fails
Date: Fri, 13 Jan 2012 11:00:50 +0100 [thread overview]
Message-ID: <1326448850.3123.2.camel@realization> (raw)
In-Reply-To: <1326445253.12667.1.camel@phoenix>
Hi Axel,
On Fri, 2012-01-13 at 17:00 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/video/backlight/l4f00242t03.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/backlight/l4f00242t03.c b/drivers/video/backlight/l4f00242t03.c
> index fae421a..6022b67 100644
> --- a/drivers/video/backlight/l4f00242t03.c
> +++ b/drivers/video/backlight/l4f00242t03.c
> @@ -190,6 +190,7 @@ static int __devinit l4f00242t03_probe(struct spi_device *spi)
>
> priv->io_reg = regulator_get(&spi->dev, "vdd");
> if (IS_ERR(priv->io_reg)) {
> + ret = PTR_ERR(priv->io_reg);
> dev_err(&spi->dev, "%s: Unable to get the IO regulator\n",
> __func__);
> goto err3;
> @@ -197,6 +198,7 @@ static int __devinit l4f00242t03_probe(struct spi_device *spi)
>
> priv->core_reg = regulator_get(&spi->dev, "vcore");
> if (IS_ERR(priv->core_reg)) {
> + ret = PTR_ERR(priv->core_reg);
> dev_err(&spi->dev, "%s: Unable to get the core regulator\n",
> __func__);
> goto err4;
Of course, I totally missed them..
Acked-by: Alberto Panizzo <alberto@amarulasolutions.com>
Thank you,
Alberto
prev parent reply other threads:[~2012-01-13 10:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 9:00 [PATCH] backlight: Return proper error in l4f00242t03_probe if regulator_get fails Axel Lin
2012-01-13 10:00 ` Alberto Panizzo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326448850.3123.2.camel@realization \
--to=maramaopercheseimorto@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox