From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932488AbdA3QX3 (ORCPT ); Mon, 30 Jan 2017 11:23:29 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:52787 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932469AbdA3QXV (ORCPT ); Mon, 30 Jan 2017 11:23:21 -0500 X-AuditID: b6c32a37-f79196d000001a39-b8-588f6843aed7 From: Bartlomiej Zolnierkiewicz To: Geliang Tang Cc: linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] video/mbx: use simple_open() Date: Mon, 30 Jan 2017 17:22:23 +0100 Message-id: <13269025.Q9kkMo78lp@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <70f5253031d545642db17d64535f228752c12e6e.1484903730.git.geliangtang@gmail.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrPIsWRmVeSWpSXmKPExsWy7bCmvq5zRn+EwdFpShZ39vYyW5zo+8Bq cXnXHDYHZo+ds+6ye3zeJBfAFMVlk5Kak1mWWqRvl8CVsefjDKaCZuGKPe/3MTcw9vJ3MXJy SAiYSLzY+5kFwhaTuHBvPVsXIxeHkMAORol9F1YxgySEBNqZJC70mcM0PNx+mh2iaA6jxNpX 61ghnK+MEp1HN7ODVLEJWElMbF/FCGKLCGhINLV+YwWxmQVsJV6fPgMWFxYwlGhqPAJmswio Sjyb/gJsG6+AlsTqz91gJ4kKeEls2dfOBGJzCsRJTOv/zwJRIyjxY/I9FoiZ8hL79k+Fmq8j cfbYOkaQgyQEXrNJvF/YAdTMAeTISmw6wAxhukhc3O4K8YywxKvjW9ghbGmJVf9uMUHY0xkl tv+WgBizmVFi1e4JUEXWEoePX4TaxSfx7msPK8RMXomONiGIEg+JhplHmCFsR4mfn+YwQsKn kUniUmMj0wRG+VlIXpiF5IVZSF5YwMi8ilEstaA4Nz212LDAWK84Mbe4NC9dLzk/dxMjOBlo me9g3HDO5xCjAAejEg/vDeG+CCHWxLLiytxDjBIczEoivGzJ/RFCvCmJlVWpRfnxRaU5qcWH GKU5WJTEeRc3WkcICaQnlqRmp6YWpBbBZJk4OKUaGM1efdvj/76h6dtOZ+O28IftNpwXr7QI XlvUx8PqfM2Yx3L29Wv65tUFK658iWGoF9n+l5lhX5CygPTnq1r77z+yDdRxDHi59vPZ7d4e KksO/bnSXu7sIRb16cQOK2XX7gULXuve3PE068Ih7xOLP/L0z3smmXvo8q8FLbVTr4c8Mlb2 fddYuFiJpTgj0VCLuag4EQBYDw3uAgMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMIsWRmVeSWpSXmKPExsVy+t9jQV2njP4Ig0m75S3u7O1ltjjR94HV 4vKuOWwOzB47Z91l9/i8SS6AKcrNJiM1MSW1SCE1Lzk/JTMv3VYpNMRN10JJIS8xN9VWKULX NyRISaEsMacUyDMyQAMOzgHuwUr6dgluGXs+zmAqaBau2PN+H3MDYy9/FyMnh4SAicTD7afZ IWwxiQv31rN1MXJxCAnMYpT4ubYFyvnKKHHg9Uc2kCo2ASuJie2rGEFsEQENiabWb6wgNrOA rcTr02fA4sIChhJNjUfAbBYBVYln018wg9i8AloSqz93s4DYogJeElv2tTOB2JwCcRLHuw5A LWtmkrje8pkRokFQ4sfkeywQC+Ql9u2fCrVMS2L9zuNMExiB7kQom4WkbBaSsgWMzKsYJVIL kguKk9JzDfNSy/WKE3OLS/PS9ZLzczcxgiPkmdQOxoO73A8xCnAwKvHwbkjvjxBiTSwrrsw9 xCjBwawkwsuWDBTiTUmsrEotyo8vKs1JLT7EaAr04URmKdHkfGD05pXEG5qYm5gbG1iYW1qa GCmJ8zbOfhYuJJCeWJKanZpakFoE08fEwSnVwChx5dbXPcf5zx6p1mXR38Jx8PrpPzYZ6z+x WaQeOsv/qVjGpcz4RNeTGylfGl/25Pf/fdBV5yrDYXViP8sb/XaxBGY2K4uSP2yCjTm3Xjxl Puva43rcs0n6c7fVpOuLUvq3azT/Su5k1JlcciLzEI9qSHzYmzSxdE3RozLdnoZiHcmz5k4X UWIpzkg01GIuKk4EAGYVTbGmAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170130162226epcas1p32f2e6f1c5ab38a78a8d7f41bad1ad7b6 X-Msg-Generator: CA X-Sender-IP: 203.254.230.26 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-HopCount: 7 X-CMS-RootMailID: 20170120142721epcas3p32a9fc0e4fbfba5dc01dc62c44a2dc7b6 X-RootMTR: 20170120142721epcas3p32a9fc0e4fbfba5dc01dc62c44a2dc7b6 References: <697f2692562e48afa03304a7e605e8adbee8437e.1484829069.git.geliangtang@gmail.com> <70f5253031d545642db17d64535f228752c12e6e.1484903730.git.geliangtang@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday, January 20, 2017 10:27:05 PM Geliang Tang wrote: > Drop open_file_generic(), use simple_open() instead of it. > > Signed-off-by: Geliang Tang Thanks, patch queued for 4.11. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > --- > drivers/video/fbdev/mbx/mbxdebugfs.c | 18 ++++++------------ > 1 file changed, 6 insertions(+), 12 deletions(-) > > diff --git a/drivers/video/fbdev/mbx/mbxdebugfs.c b/drivers/video/fbdev/mbx/mbxdebugfs.c > index e3bc00a..2528d3e 100644 > --- a/drivers/video/fbdev/mbx/mbxdebugfs.c > +++ b/drivers/video/fbdev/mbx/mbxdebugfs.c > @@ -15,12 +15,6 @@ struct mbxfb_debugfs_data { > struct dentry *misc; > }; > > -static int open_file_generic(struct inode *inode, struct file *file) > -{ > - file->private_data = inode->i_private; > - return 0; > -} > - > static ssize_t write_file_dummy(struct file *file, const char __user *buf, > size_t count, loff_t *ppos) > { > @@ -174,42 +168,42 @@ static ssize_t misc_read_file(struct file *file, char __user *userbuf, > static const struct file_operations sysconf_fops = { > .read = sysconf_read_file, > .write = write_file_dummy, > - .open = open_file_generic, > + .open = simple_open, > .llseek = default_llseek, > }; > > static const struct file_operations clock_fops = { > .read = clock_read_file, > .write = write_file_dummy, > - .open = open_file_generic, > + .open = simple_open, > .llseek = default_llseek, > }; > > static const struct file_operations display_fops = { > .read = display_read_file, > .write = write_file_dummy, > - .open = open_file_generic, > + .open = simple_open, > .llseek = default_llseek, > }; > > static const struct file_operations gsctl_fops = { > .read = gsctl_read_file, > .write = write_file_dummy, > - .open = open_file_generic, > + .open = simple_open, > .llseek = default_llseek, > }; > > static const struct file_operations sdram_fops = { > .read = sdram_read_file, > .write = write_file_dummy, > - .open = open_file_generic, > + .open = simple_open, > .llseek = default_llseek, > }; > > static const struct file_operations misc_fops = { > .read = misc_read_file, > .write = write_file_dummy, > - .open = open_file_generic, > + .open = simple_open, > .llseek = default_llseek, > };