From: Sam Hansen <solid.se7en@gmail.com>
To: Arnaud Patard <arnaud.patard@rtp-net.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Sam Hansen <solid.se7en@gmail.com>
Subject: [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN_*
Date: Sat, 21 Jan 2012 02:10:12 -0800 [thread overview]
Message-ID: <1327140612-9694-3-git-send-email-solid.se7en@gmail.com> (raw)
In-Reply-To: <1327140612-9694-1-git-send-email-solid.se7en@gmail.com>
Added KERN_ facility levels in XGI_main_26.c and vb_init.c in a few different
printk() statements.
Signed-off-by: Sam Hansen <solid.se7en@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 16 ++++++++--------
drivers/staging/xgifb/vb_init.c | 2 +-
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index a743e1b..389768d 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -1711,7 +1711,7 @@ static int XGIfb_get_dram_size(struct xgifb_video_info *xgifb_info)
/* xgifb_info->video_size = 0x200000; */ /* 1024x768x16 */
/* xgifb_info->video_size = 0x1000000; */ /* benchmark */
- printk("XGIfb: SR14=%x DramSzie %x ChannelNum %x\n",
+ printk(KERN_INFO "XGIfb: SR14=%x DramSzie %x ChannelNum %x\n",
reg,
xgifb_info->video_size, ChannelNum);
return 0;
@@ -1917,7 +1917,7 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
xgifb_info->vga_base = pci_resource_start(pdev, 2) + 0x30;
hw_info->pjIOAddress = (unsigned char *)xgifb_info->vga_base;
/* XGI_Pr.RelIO = ioremap(pci_resource_start(pdev, 2), 128) + 0x30; */
- printk("XGIfb: Relocate IO address: %lx [%08lx]\n",
+ printk(KERN_INFO "XGIfb: Relocate IO address: %lx [%08lx]\n",
(unsigned long)pci_resource_start(pdev, 2),
xgifb_info->dev_info.RelIO);
@@ -1937,7 +1937,7 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
reg1 = xgifb_reg_get(XGISR, IND_XGI_PASSWORD);
if (reg1 != 0xa1) { /*I/O error */
- printk("\nXGIfb: I/O error!!!");
+ printk(KERN_ERR "\nXGIfb: I/O error!!!");
ret = -EIO;
goto error;
}
@@ -1989,7 +1989,7 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
if (!request_mem_region(xgifb_info->video_base,
xgifb_info->video_size,
"XGIfb FB")) {
- printk("unable request memory size %x",
+ printk(KERN_ERR "unable to request memory size %x",
xgifb_info->video_size);
printk(KERN_ERR "XGIfb: Fatal error: Unable to reserve frame buffer memory\n");
printk(KERN_ERR "XGIfb: Is there another framebuffer driver active?\n");
@@ -2018,12 +2018,12 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
printk(KERN_INFO "XGIfb: MMIO at 0x%lx, mapped to 0x%p, size %ldk\n",
xgifb_info->mmio_base, xgifb_info->mmio_vbase,
xgifb_info->mmio_size / 1024);
- printk("XGIfb: XGIInitNew() ...");
+ printk(KERN_INFO "XGIfb: XGIInitNew() ...");
pci_set_drvdata(pdev, xgifb_info);
if (XGIInitNew(pdev))
- printk("OK\n");
+ printk(KERN_INFO "OK\n");
else
- printk("Fail\n");
+ printk(KERN_ERR "Fail\n");
xgifb_info->mtrr = (unsigned int) 0;
@@ -2064,7 +2064,7 @@ static int __devinit xgifb_probe(struct pci_dev *pdev,
} */
else {
hw_info->ujVBChipID = VB_CHIP_301;
- printk("XGIfb: XGI301 bridge detected\n");
+ printk(KERN_INFO "XGIfb: XGI301 bridge detected\n");
}
break;
case HASVB_302:
diff --git a/drivers/staging/xgifb/vb_init.c b/drivers/staging/xgifb/vb_init.c
index 4ccd988..2b72e26 100644
--- a/drivers/staging/xgifb/vb_init.c
+++ b/drivers/staging/xgifb/vb_init.c
@@ -1483,7 +1483,7 @@ unsigned char XGIInitNew(struct pci_dev *pdev)
/* Newdebugcode(0x99); */
if (pVBInfo->FBAddr == NULL) {
- printk("\n pVBInfo->FBAddr == 0 ");
+ printk(KERN_INFO "\n pVBInfo->FBAddr == 0 ");
return 0;
}
printk("1");
--
1.7.5.4
next prev parent reply other threads:[~2012-01-21 10:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 10:10 [PATCH 1/3] xgifb: checkpatch cleanup, braces Sam Hansen
2012-01-21 10:10 ` [PATCH 2/3] xgifb: checkpatch cleanup __func__ Sam Hansen
2012-01-21 10:10 ` Sam Hansen [this message]
2012-01-21 15:52 ` [PATCH 3/3] xgifb: checkpatch cleanup, printk() KERN_* Dan Carpenter
2012-01-21 17:13 ` sam hansen
2012-01-21 16:42 ` Joe Perches
2012-01-21 17:18 ` sam hansen
2012-01-21 19:22 ` sam hansen
2012-01-21 19:45 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327140612-9694-3-git-send-email-solid.se7en@gmail.com \
--to=solid.se7en@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=arnaud.patard@rtp-net.org \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox