From: John Stultz <john.stultz@linaro.org>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH 2/3] clocksource: scx200_hrt: Convert scx200 to use clocksource_register_hz
Date: Tue, 24 Jan 2012 16:14:59 -0800 [thread overview]
Message-ID: <1327450499.11738.45.camel@work-vm> (raw)
In-Reply-To: <CAJfuBxw6M7LB_-GpmTxem-aqWz35CDDaaBv+8oqQ_R_SR7r_tQ@mail.gmail.com>
On Tue, 2012-01-24 at 16:51 -0700, Jim Cromie wrote:
> On Tue, Jan 24, 2012 at 4:00 PM, John Stultz <john.stultz@linaro.org> wrote:
> > On Tue, 2012-01-24 at 11:53 -0700, Jim Cromie wrote:
> >> very nice. Tested with mhz27 too.
> >>
> >> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
> >
> > I assume you mean Acked-by:/Tested-by: ? Or are you going to push this
> > upstream?
> >
>
> huh - I thought SOB was appropriate since Im maintainer of scx200_hrt.
> That said, youre maintainer of TIMEKEEPING, and author of the patch,
> so I consider you upstream. Lets make it instead:
>
> Acked-by: Jim Cromie <jim.cromie@gmail.com>
> Tested-by: Jim Cromie <jim.cromie@gmail.com>
Thanks for clarifying. It might be good to review section 12-14 here (I
have to re-read it periodically myself):
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob_plain;f=Documentation/SubmittingPatches
If you're planning on distributing the patch yourself (pushing it up
towards Linus or giving it to someone else via a git tree or something),
then adding the signed-off-by would be appropriate (although not
necessarily in an email reply - usually just better to tell folks you've
queued it) before sending it onward.
Otherwise if you're not in the distribution path, an Acked-by: would be
more appropriate.
> Can you also push that trivial s/then/than/ patch I attached,
> and/or should I resend it inline, with git-send-email ?
Yep. I've just queued it into my tree. Thanks for that!
thanks
-john
next prev parent reply other threads:[~2012-01-25 0:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 0:05 [RFC][PATCH 0/3] Last of the clocksource_register_hz cleanups John Stultz
2012-01-24 0:05 ` [RFC][PATCH 1/3] clocksource: s390: Convert s390 to use clocksource_register_khz John Stultz
2012-01-24 0:05 ` [RFC][PATCH 2/3] clocksource: scx200_hrt: Convert scx200 to use clocksource_register_hz John Stultz
2012-01-24 18:53 ` Jim Cromie
2012-01-24 23:00 ` John Stultz
2012-01-24 23:51 ` Jim Cromie
2012-01-25 0:14 ` John Stultz [this message]
2012-01-24 0:05 ` [PATCH 3/3] clocksource: Convert mips pnx8550 " John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327450499.11738.45.camel@work-vm \
--to=john.stultz@linaro.org \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox