From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752827Ab2AYPKT (ORCPT <rfc822;w@1wt.eu>);
	Wed, 25 Jan 2012 10:10:19 -0500
Received: from casper.infradead.org ([85.118.1.10]:59475 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751274Ab2AYPKQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 25 Jan 2012 10:10:16 -0500
Subject: Re: [RFC PATCH v1 1/2] sched: unified sched_powersavings sysfs
 tunable
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
        Indan Zupancic <indan@nul.nu>, Youquan Song <youquan.song@intel.com>,
        Ingo Molnar <mingo@elte.hu>, Arjan van de Ven <arjan@linux.intel.com>,
        Suresh Siddha <suresh.b.siddha@intel.com>,
        Linux Kernel <linux-kernel@vger.kernel.org>
In-Reply-To: <20120116162241.29759.13220.stgit@localhost>
References: <20120116161740.29759.4679.stgit@localhost>
	 <20120116162241.29759.13220.stgit@localhost>
Content-Type: text/plain; charset="UTF-8"
Date: Wed, 25 Jan 2012 16:10:13 +0100
Message-ID: <1327504213.2614.78.camel@laptop>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.2 
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2012-01-16 at 21:52 +0530, Vaidyanathan Srinivasan wrote:
> @@ -6150,10 +6150,8 @@ SD_INIT_FUNC(CPU)
>   SD_INIT_FUNC(ALLNODES)
>   SD_INIT_FUNC(NODE)
>  #endif
> -#ifdef CONFIG_SCHED_SMT
> +#ifdef CONFIG_SCHED_POWERSAVE
>   SD_INIT_FUNC(SIBLING)
> -#endif
> -#ifdef CONFIG_SCHED_MC
>   SD_INIT_FUNC(MC)
>  #endif
>  #ifdef CONFIG_SCHED_BOOK
> @@ -6250,7 +6248,7 @@ static void claim_allocations(int cpu, struct sched_domain *sd)
>                 *per_cpu_ptr(sdd->sgp, cpu) = NULL;
>  }
>  
> -#ifdef CONFIG_SCHED_SMT
> +#ifdef CONFIG_SCHED_POWERSAVE
>  static const struct cpumask *cpu_smt_mask(int cpu)
>  {
>         return topology_thread_cpumask(cpu);
> @@ -6261,10 +6259,8 @@ static const struct cpumask *cpu_smt_mask(int cpu)
>   * Topology list, bottom-up.
>   */
>  static struct sched_domain_topology_level default_topology[] = {
> -#ifdef CONFIG_SCHED_SMT
> +#ifdef CONFIG_SCHED_POWERSAVE
>         { sd_init_SIBLING, cpu_smt_mask, },
> -#endif
> -#ifdef CONFIG_SCHED_MC
>         { sd_init_MC, cpu_coregroup_mask, },
>  #endif
>  #ifdef CONFIG_SCHED_BOOK 

I don't like this either, SCHED_{MC,SMT} here have nothing to do with
powersavings, its topology support.