From: David Sharp <dhsharp@google.com>
To: rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, mrubin@google.com,
chavey@google.com, David Sharp <dhsharp@google.com>
Subject: [PATCH] trace-cmd: fix length calculation for padding events
Date: Thu, 26 Jan 2012 19:00:15 -0800 [thread overview]
Message-ID: <1327633215-4013-1-git-send-email-dhsharp@google.com> (raw)
Padding events store size in bytes, not words. Usually this ends up pushing
the parser off the current page, but occasionally not, and when not,
it ends up desynchronizing the parser from the event stream. This would
manifest as a lot of "ug!" messages from trace-cmd, and kernelshark
crashing before displaying the UI.
Signed-off-by: David Sharp <dhsharp@google.com>
---
trace-input.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/trace-input.c b/trace-input.c
index e3157a7..b6af1e6 100644
--- a/trace-input.c
+++ b/trace-input.c
@@ -1458,7 +1458,6 @@ translate_data(struct pevent *pevent,
switch (type_len) {
case RINGBUF_TYPE_PADDING:
*length = data2host4(pevent, *ptr);
- *length *= 4;
*ptr += *length;
break;
--
1.7.7.3
next reply other threads:[~2012-01-27 3:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 3:00 David Sharp [this message]
2012-01-27 3:44 ` [PATCH] trace-cmd: fix length calculation for padding events Steven Rostedt
2012-01-27 19:21 ` David Sharp
2012-01-27 19:31 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327633215-4013-1-git-send-email-dhsharp@google.com \
--to=dhsharp@google.com \
--cc=chavey@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mrubin@google.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox