From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755741Ab2BACwB (ORCPT ); Tue, 31 Jan 2012 21:52:01 -0500 Received: from mail-pz0-f46.google.com ([209.85.210.46]:57438 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753495Ab2BACwA (ORCPT ); Tue, 31 Jan 2012 21:52:00 -0500 Message-ID: <1328064713.3533.3.camel@phoenix> Subject: [PATCH 2/2 RESEND] gpio: Add missing spin_lock_init in gpio-pch driver From: Axel Lin To: linux-kernel@vger.kernel.org Cc: Tomoya MORINAGA , Feng Tang , Grant Likely , Linus Walleij Date: Wed, 01 Feb 2012 10:51:53 +0800 In-Reply-To: <1328064605.3533.1.camel@phoenix> References: <1328064605.3533.1.camel@phoenix> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.1- Content-Transfer-Encoding: 7bit Mime-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This bug was introduced by commit d568a681 "gpio-pch: add spinlock in suspend/resume processing" which adds a spinlock to struct pch_gpio but never init the spinlock. Reported-by: Tomoya MORINAGA Signed-off-by: Axel Lin Acked-by: Linus Walleij --- drivers/gpio/gpio-pch.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c index f060329..e84eabf 100644 --- a/drivers/gpio/gpio-pch.c +++ b/drivers/gpio/gpio-pch.c @@ -392,6 +392,7 @@ static int __devinit pch_gpio_probe(struct pci_dev *pdev, chip->reg = chip->base; pci_set_drvdata(pdev, chip); mutex_init(&chip->lock); + spin_lock_init(&chip->spinlock); pch_gpio_setup(chip); ret = gpiochip_add(&chip->gpio); if (ret) { -- 1.7.5.4