Re: Regression 3.2 -> 3.3-rc1 10 sec hang at boot and resume, COMRESET failed

Brian Norris
2012-02-15T05:15:34Z

On Mon, Feb 13, 2012 at 9:44 AM, Tejun Heo <tj@kernel.org> wrote:
> Hello,
>
> On Mon, Feb 06, 2012 at 11:20:45AM -0800, Brian Norris wrote:
>> I see the following options:
>> (1) implement a flag that can be passed through ahci_platform; this
>> would not be very useful, as we would still have to tweak the driver
>> out of tree.
>
> Yeah, please add module param to make this behavior conditional.

Perhaps a module param (for ahci_platform) that sets a flag in
ata_port_info? I'm not sure if/how I'm allowed to introduce new ATA
flags...

>> (2) Drop the fix entirely. This is a spec. violation, but we can
>> simply try to maintain the fix out-of-tree.
>
> Nothing is perfect and real hardware should come before spec.

You have ignored my option (3): to fix the observed problems. I
already tested this last patch against the previous regression
reports, found here:
http://marc.info/?l=linux-ide&m=130529205513940&w=2

However, I had not noticed that the delayed DVD drive recognition was
a separate issue. Since then, I've noticed that I have tested the
exact same AHCI controller as Valdis' issue (a little different than
Norbert's) but the key difference is the MATSHITA DVD drive (both
Norbert and Valdis have MATSHITA). The same controller works with
non-MATSHITA DVD.

I also noticed that Mark Lord commented that he needed the patch in
question. Is this a different controller that needs my same fix?
http://marc.info/?l=linux-ide&m=131967244009803&w=2

So it appears that we are weighing the MATSHITA DVD issues against the
issues seen by me and possibly Mark Lord. If the decision really
stands that finding a unified solution is impossible, then I can just
drop the issue and make conditional behavior.

Brian