Re: [PATCH] checkpatch: Check for quoted strings broken across lines

Josh Triplett
2012-03-21T04:28:19Z

On Tue, Mar 20, 2012 at 06:24:16PM -0700, Joe Perches wrote:
> On Tue, 2012-03-20 at 14:06 -0700, Josh Triplett wrote:
> > checkpatch already makes an exception to the 80-column rule for quoted
> > strings, and Documentation/CodingStyle recommends not splitting quoted
> > strings across lines, because it breaks the ability to grep for the
> > string. Rather than just permitting this, actively warn about quoted
> > strings split across lines.
>
> Hi Josh.
>
> I don't recall seeing your patch before, but I submitted
> a similar one that I believe Andrew has in his tree.

You reviewed my patch at the time and provided feedback, and I'd
produced a revised version based on that feedback.

> https://lkml.org/lkml/2012/3/2/24

The heuristics in the patch I submitted almost completely eliminate
false positives, which makes my patch suitable for use without --strict.
Having a --strict version which flags *all* wrapped strings seems
potentially reasonable as well (though you'll still want the heuristic
that ignores strings ending in \n or \n\t), but I'd still like to get my
version included with the heuristics that make it suitable as a default.

Among other things, the version you submitted to Andrew will flag
multi-instruction __asm__ directives, multi-line strings printed with a
single printk, and arrays of arbitrary data expressed as strings.

- Josh Triplett