From: Alex Elder <elder@dreamhost.com>
To: Xi Wang <xi.wang@gmail.com>
Cc: Sage Weil <sage@newdream.net>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] ceph: avoid panic with mismatched symlink sizes in fill_inode()
Date: Fri, 03 Feb 2012 14:24:32 -0600 [thread overview]
Message-ID: <1328300672.21405.90.camel@doink> (raw)
In-Reply-To: <1328280936-2688-1-git-send-email-xi.wang@gmail.com>
On Fri, 2012-02-03 at 09:55 -0500, Xi Wang wrote:
> Return -EINVAL rather than panic if iinfo->symlink_len and
> inode->i_size do not match.
>
> Also use kstrndup rather than kmalloc/memcpy.
>
> Signed-off-by: Xi Wang <xi.wang@gmail.com>
Looks good, though it might good to at least call
WARN_ON(). What do you think?
I will commit this (either with or without the
WARN_ON()).
Reviewed-by: Alex Elder <elder@dreamhost.com>
next prev parent reply other threads:[~2012-02-03 20:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 14:55 [PATCH RESEND] ceph: avoid panic with mismatched symlink sizes in fill_inode() Xi Wang
2012-02-03 20:24 ` Alex Elder [this message]
2012-02-03 20:49 ` Xi Wang
2012-02-03 21:04 ` Alex Elder
2012-02-03 20:57 ` [PATCH v2] " Xi Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328300672.21405.90.camel@doink \
--to=elder@dreamhost.com \
--cc=ceph-devel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sage@newdream.net \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox