From: Joe Perches <joe@perches.com>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH 1/3] apple_bl: Convert printks to pr_<level>
Date: Fri, 03 Feb 2012 12:39:50 -0800 [thread overview]
Message-ID: <1328301590.18218.8.camel@joe2Laptop> (raw)
In-Reply-To: <1328300884-21551-2-git-send-email-seth.forshee@canonical.com>
On Fri, 2012-02-03 at 14:28 -0600, Seth Forshee wrote:
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
[]
> diff --git a/drivers/video/backlight/apple_bl.c b/drivers/video/backlight/apple_bl.c
> @@ -58,9 +53,7 @@ static int intel_chipset_send_intensity(struct backlight_device *bd)
> {
> int intensity = bd->props.brightness;
>
> - if (debug)
> - printk(KERN_DEBUG DRIVER "setting brightness to %d\n",
> - intensity);
> + pr_debug("setting brightness to %d\n", intensity);
You may need to add "#define DEBUG" somewhere for
this to work as you might expect it to.
An "allyesconfig" does effectively add one.
next prev parent reply other threads:[~2012-02-03 20:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 20:28 [PATCH 0/3] apple_bl: Add support for gmux backlight control Seth Forshee
2012-02-03 20:28 ` [PATCH 1/3] apple_bl: Convert printks to pr_<level> Seth Forshee
2012-02-03 20:39 ` Joe Perches [this message]
2012-02-05 23:23 ` Ryan Mallon
2012-02-06 14:35 ` Seth Forshee
2012-02-06 21:47 ` Ryan Mallon
2012-02-03 20:28 ` [PATCH 2/3] apple_bl: Rework in advance of gmux backlight support Seth Forshee
2012-02-03 22:25 ` Lars-Peter Clausen
2012-02-03 22:51 ` Seth Forshee
2012-02-04 17:25 ` Lars-Peter Clausen
2012-02-06 14:56 ` Seth Forshee
2012-02-09 17:20 ` Seth Forshee
2012-02-10 9:25 ` Lars-Peter Clausen
2012-02-10 14:50 ` Seth Forshee
2012-02-03 20:28 ` [PATCH 3/3] apple_bl: Add support for gmux backlight control Seth Forshee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328301590.18218.8.camel@joe2Laptop \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=rpurdie@rpsys.net \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox