From: Shaohua Li <shaohua.li@intel.com>
To: Tejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Vivek Goyal <vgoyal@redhat.com>, Jens Axboe <axboe@kernel.dk>,
lkml <linux-kernel@vger.kernel.org>,
Knut Petersen <Knut_Petersen@t-online.de>,
mroos@linux.ee
Subject: Re: [patch]block: fix ioc locking warning
Date: Tue, 07 Feb 2012 08:43:50 +0800 [thread overview]
Message-ID: <1328575430.21268.69.camel@sli10-conroe> (raw)
In-Reply-To: <20120207003948.GE21292@google.com>
On Mon, 2012-02-06 at 16:39 -0800, Tejun Heo wrote:
> Hello,
>
> On Tue, Feb 07, 2012 at 08:31:22AM +0800, Shaohua Li wrote:
> > Since you are talking about performance, one of our microbenchmark (swap)
> > shows a regression. Alex bisect it to be b2efa05265d62bc2, which is related to
> > the ioc change. A little strange to me, don't expect such change can cause
> > performance issue. I haven't double check the issue, but if you have
> > ideas, please let me know.
>
> Hmmm... I think the only thing which can be made slower by that patch
> is ioc release (ie. task exits). What does the microbench do?
Quite simple, copy kernel source to tmpfs in tight memory environment.
This will trigger swap. The bisection result appears stable.
Thanks,
Shaohua
next prev parent reply other threads:[~2012-02-07 0:45 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-06 7:50 [patch]block: fix ioc locking warning Shaohua Li
2012-02-06 7:55 ` Jens Axboe
2012-02-06 15:12 ` Vivek Goyal
2012-02-06 16:09 ` Jens Axboe
2012-02-06 16:37 ` Vivek Goyal
2012-02-06 16:44 ` Tejun Heo
2012-02-06 16:58 ` Linus Torvalds
2012-02-06 17:27 ` Tejun Heo
2012-02-06 20:16 ` Jens Axboe
2012-02-06 21:54 ` [PATCH] block: strip out locking optimization in put_io_context() Tejun Heo
2012-02-07 6:49 ` Jens Axboe
2012-02-07 16:22 ` Tejun Heo
2012-02-07 16:28 ` Jens Axboe
2012-02-07 16:33 ` Linus Torvalds
2012-02-07 16:47 ` Tejun Heo
2012-02-07 17:17 ` Tejun Heo
2012-02-08 0:19 ` Shaohua Li
2012-02-08 8:29 ` Shaohua Li
2012-02-08 16:29 ` Tejun Heo
2012-02-08 16:34 ` Linus Torvalds
2012-02-08 16:49 ` Tejun Heo
2012-02-08 16:56 ` Tejun Heo
2012-02-08 17:23 ` Tejun Heo
2012-02-09 6:22 ` Shaohua Li
2012-02-09 17:59 ` Tejun Heo
2012-02-09 18:07 ` Linus Torvalds
2012-02-09 19:24 ` Tejun Heo
2012-02-09 23:48 ` Tejun Heo
2012-02-10 5:14 ` Shaohua Li
2012-02-10 8:48 ` Shaohua Li
2012-02-11 2:17 ` Tejun Heo
2012-02-11 11:35 ` Jens Axboe
2012-02-13 1:34 ` Shaohua Li
2012-02-13 20:49 ` Tejun Heo
2012-02-14 2:36 ` Shaohua Li
2012-02-14 16:39 ` Tejun Heo
2012-02-10 3:09 ` Shaohua Li
2012-02-07 23:00 ` [PATCH] block: fix lockdep warning on io_context release put_io_context() Tejun Heo
2012-02-06 20:36 ` [patch]block: fix ioc locking warning Tejun Heo
2012-02-07 0:31 ` Shaohua Li
2012-02-07 0:39 ` Tejun Heo
2012-02-07 0:43 ` Shaohua Li [this message]
2012-02-07 0:59 ` Tejun Heo
2012-02-07 1:10 ` Shaohua Li
2012-02-07 1:33 ` Shaohua Li
2012-02-07 5:22 ` Shaohua Li
2012-02-07 22:34 ` Linus Torvalds
2012-02-06 16:22 ` Tejun Heo
2012-02-08 18:07 ` walt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328575430.21268.69.camel@sli10-conroe \
--to=shaohua.li@intel.com \
--cc=Knut_Petersen@t-online.de \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox