From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH 1/2] regulator: Don't add the function name to pr_fmt
Date: Thu, 09 Feb 2012 15:23:49 +0000 [thread overview]
Message-ID: <1328801029.3951.7.camel@odin> (raw)
In-Reply-To: <1328794926-4892-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On Thu, 2012-02-09 at 13:42 +0000, Mark Brown wrote:
> Liam pointed out via IM that since we now use the pure function name for
> all regulator logging a lot of the messages such as those logging the
> constraints are getting a bit noisy due to the implementation detail
> that is the function name:
>
> print_constraints: VDDARM: 1000 <--> 1300 mV at 1300 mV at 0 mA
>
> In discussion it seemed like the best thing was to just drop the pr_fmt
> and clarify individual log messages where there is an issue otherwise
> we get into silly things like renaming the functions to suit the logging.
>
> This is mostly an issue as we have a moderate amount of non-error logging
> in the boot sequence to aid debug if something goes wrong since regulator
> misconfiguration can kill the system pretty quickly.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Both
Acked-by: Liam Girdwood <lrg@ti.com>
prev parent reply other threads:[~2012-02-09 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-09 13:42 [PATCH 1/2] regulator: Don't add the function name to pr_fmt Mark Brown
2012-02-09 13:42 ` [PATCH 2/2] regulator: Complain if a voltage range is specified but can't be used Mark Brown
2012-02-09 15:23 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1328801029.3951.7.camel@odin \
--to=lrg@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox