linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Don Zickus <dzickus@redhat.com>
To: <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	tony.luck@intel.com, seiji.aguchi@hds.com, ak@linux.intel.com,
	mjg@redhat.com, levinsasha928@gmail.com,
	Don Zickus <dzickus@redhat.com>
Subject: [PATCH 0/2] x86, reboot: cleanup NMI and REBOOT_IRQ
Date: Fri, 10 Feb 2012 16:02:13 -0500	[thread overview]
Message-ID: <1328907735-6226-1-git-send-email-dzickus@redhat.com> (raw)

After dealing with pstore conversations about spin locks, I had an idea
to simplify the native_smp_stop_other_cpus() path by using both REBOOT_IRQ
and NMI instead of using either or.

I also cleaned up a WARN_ON splat from rescheduling.

Tested 10 panics on my core2 quad using 'echo c > /proc/sysrq-trigger' and
panic=10 on the commandline.  The machine panic'd and rebooted succesfully
all 10 times.  Though only the first time did I see the WARN_ON splat, the
other 9 times I couldn't duplicate it.

Don Zickus (2):
  x86, reboot: revert stop_other_cpus to using IRQ with NMI fallback
  x86, reschedule: check to see if system is shutting down

 arch/x86/kernel/smp.c |  104 +++++++++++++++++++++++--------------------------
 1 files changed, 49 insertions(+), 55 deletions(-)

-- 
1.7.7.6


             reply	other threads:[~2012-02-10 21:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-10 21:02 Don Zickus [this message]
2012-02-10 21:02 ` [PATCH 1/2] x86, reboot: revert stop_other_cpus to using IRQ with NMI fallback Don Zickus
2012-02-10 21:02 ` [PATCH 2/2] x86, reschedule: check to see if system is shutting down Don Zickus
2012-02-10 22:42   ` Luck, Tony
2012-02-10 22:53     ` Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1328907735-6226-1-git-send-email-dzickus@redhat.com \
    --to=dzickus@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=seiji.aguchi@hds.com \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).